Changeset 168230 in webkit

Timestamp:

May 3, 2014 3:16:53 PM (10 years ago)

Author:

akling@apple.com

Message:

Invalidate scrollbars when custom scrollbar style changes dynamically.
<​https://webkit.org/b/132529>

Source/WebCore:
Add a ScrollView::styleDidChange() and call that from RenderView::styleDidChange()
so that the scrollbars are sure to get repainted with potentially different style.

Reviewed by Antti Koivisto.

Test: fast/css/scrollbar-dynamic-style-change.html

• platform/ScrollView.cpp:

(WebCore::ScrollView::styleDidChange):

• platform/ScrollView.h:
• rendering/RenderView.cpp:

(WebCore::RenderView::styleDidChange):

LayoutTests:
Reviewed by Antti Koivisto.

• fast/css/scrollbar-dynamic-style-change-expected.html: Added.
• fast/css/scrollbar-dynamic-style-change.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/css/scrollbar-dynamic-style-change-expected.html (added)
• LayoutTests/fast/css/scrollbar-dynamic-style-change.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/ScrollView.cpp (modified) (1 diff)
• Source/WebCore/platform/ScrollView.h (modified) (1 diff)
• Source/WebCore/rendering/RenderView.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-05-03  Andreas Kling  <akling@apple.com>
+
+        Invalidate scrollbars when custom scrollbar style changes dynamically.
+        <https://webkit.org/b/132529>
+
+        Reviewed by Antti Koivisto.
+
+        * fast/css/scrollbar-dynamic-style-change-expected.html: Added.
+        * fast/css/scrollbar-dynamic-style-change.html: Added.
+
 2014-05-03  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-05-03  Andreas Kling  <akling@apple.com>
+
+        Invalidate scrollbars when custom scrollbar style changes dynamically.
+        <https://webkit.org/b/132529>
+
+        Add a ScrollView::styleDidChange() and call that from RenderView::styleDidChange()
+        so that the scrollbars are sure to get repainted with potentially different style.
+
+        Reviewed by Antti Koivisto.
+
+        Test: fast/css/scrollbar-dynamic-style-change.html
+
+        * platform/ScrollView.cpp:
+        (WebCore::ScrollView::styleDidChange):
+        * platform/ScrollView.h:
+        * rendering/RenderView.cpp:
+        (WebCore::RenderView::styleDidChange):
+
 2014-05-03  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/platform/ScrollView.cpp

@@ -1460 +1460 @@
 }
 
+void ScrollView::styleDidChange()
+{
+    if (m_horizontalScrollbar)
+        m_horizontalScrollbar->styleChanged();
+
+    if (m_verticalScrollbar)
+        m_verticalScrollbar->styleChanged();
+}
+
 #if !PLATFORM(COCOA)
 

trunk/Source/WebCore/platform/ScrollView.h

@@ -145 +145 @@
     virtual PassRefPtr<Scrollbar> createScrollbar(ScrollbarOrientation);
 
+    void styleDidChange();
+
     // If the prohibits scrolling flag is set, then all scrolling in the view (even programmatic scrolling) is turned off.
     void setProhibitsScrolling(bool b) { m_prohibitsScrolling = b; }

trunk/Source/WebCore/rendering/RenderView.cpp

@@ -1261 +1261 @@
     if (hasRenderNamedFlowThreads())
         flowThreadController().styleDidChange();
+
+    frameView().styleDidChange();
 }