Changeset 168360 in webkit

Timestamp:

May 6, 2014 9:17:19 AM (10 years ago)

Author:

Chris Fleizach

Message:

AX: VoiceOver does not announce text changes for content editable regions in Safari
​https://bugs.webkit.org/show_bug.cgi?id=132577

Reviewed by Mario Sanchez Prada.

Source/WebCore:
When text or children are changed inside of a contenteditable region, we need to
convert those actions into AXValueChange notifications.

Test: accessibility/content-editable-set-inner-text-generates-axvalue-notification.html

• accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::childrenChanged):
(WebCore::AccessibilityNodeObject::hasContentEditableAttributeSet): Deleted.

• accessibility/AccessibilityNodeObject.h:
• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::hasContentEditableAttributeSet):

• accessibility/AccessibilityObject.h:
• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::textChanged):

LayoutTests:

• accessibility/content-editable-set-inner-text-generates-axvalue-notification-expected.txt: Added.
• accessibility/content-editable-set-inner-text-generates-axvalue-notification.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/accessibility/content-editable-set-inner-text-generates-axvalue-notification-expected.txt (added)
• LayoutTests/accessibility/content-editable-set-inner-text-generates-axvalue-notification.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/accessibility/AccessibilityNodeObject.cpp (modified) (2 diffs)
• Source/WebCore/accessibility/AccessibilityNodeObject.h (modified) (1 diff)
• Source/WebCore/accessibility/AccessibilityObject.cpp (modified) (1 diff)
• Source/WebCore/accessibility/AccessibilityObject.h (modified) (1 diff)
• Source/WebCore/accessibility/AccessibilityRenderObject.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-05-06  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: VoiceOver does not announce text changes for content editable regions in Safari
+        https://bugs.webkit.org/show_bug.cgi?id=132577
+
+        Reviewed by Mario Sanchez Prada.
+
+        * accessibility/content-editable-set-inner-text-generates-axvalue-notification-expected.txt: Added.
+        * accessibility/content-editable-set-inner-text-generates-axvalue-notification.html: Added.
+
 2014-05-06  Dirk Schulze  <krit@webkit.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-05-06  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: VoiceOver does not announce text changes for content editable regions in Safari
+        https://bugs.webkit.org/show_bug.cgi?id=132577
+
+        Reviewed by Mario Sanchez Prada.
+
+        When text or children are changed inside of a contenteditable region, we need to 
+        convert those actions into AXValueChange notifications.
+
+        Test: accessibility/content-editable-set-inner-text-generates-axvalue-notification.html
+
+        * accessibility/AccessibilityNodeObject.cpp:
+        (WebCore::AccessibilityNodeObject::childrenChanged):
+        (WebCore::AccessibilityNodeObject::hasContentEditableAttributeSet): Deleted.
+        * accessibility/AccessibilityNodeObject.h:
+        * accessibility/AccessibilityObject.cpp:
+        (WebCore::AccessibilityObject::hasContentEditableAttributeSet):
+        * accessibility/AccessibilityObject.h:
+        * accessibility/AccessibilityRenderObject.cpp:
+        (WebCore::AccessibilityRenderObject::textChanged):
+
 2014-05-06  Dirk Schulze  <krit@webkit.org>
 

trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp

@@ -153 +153 @@
         
         // If this element is an ARIA text control, notify the AT of changes.
-        if (parent->isARIATextControl() && !parent->isNativeTextControl() && !parent->node()->hasEditableStyle())
+        if ((parent->isARIATextControl() || parent->hasContentEditableAttributeSet()) && !parent->isNativeTextControl())
             cache->postNotification(parent, parent->document(), AXObjectCache::AXValueChanged);
     }
@@ -2009 +2009 @@
 }   
 
-// If you call node->hasEditableStyle() since that will return true if an ancestor is editable.
-// This only returns true if this is the element that actually has the contentEditable attribute set.
-bool AccessibilityNodeObject::hasContentEditableAttributeSet() const
-{
-    return contentEditableAttributeIsEnabled(element());
-}
-
 bool AccessibilityNodeObject::canSetSelectedAttribute() const
 {

trunk/Source/WebCore/accessibility/AccessibilityNodeObject.h

@@ -178 +178 @@
     AccessibilityRole determineAriaRoleAttribute() const;
     AccessibilityRole remapAriaRoleDueToParent(AccessibilityRole) const;
-    bool hasContentEditableAttributeSet() const;
     virtual bool isDescendantOfBarrenParent() const override;
     void alterSliderValue(bool increase);

trunk/Source/WebCore/accessibility/AccessibilityObject.cpp

@@ -1317 +1317 @@
 }
     
+// If you call node->hasEditableStyle() since that will return true if an ancestor is editable.
+// This only returns true if this is the element that actually has the contentEditable attribute set.
+bool AccessibilityObject::hasContentEditableAttributeSet() const
+{
+    return contentEditableAttributeIsEnabled(element());
+}
+
 bool AccessibilityObject::contentEditableAttributeIsEnabled(Element* element)
 {

trunk/Source/WebCore/accessibility/AccessibilityObject.h

@@ -847 +847 @@
     static bool liveRegionStatusIsEnabled(const AtomicString&);
     static bool contentEditableAttributeIsEnabled(Element*);
+    bool hasContentEditableAttributeSet() const;
     
     bool supportsARIAAttributes() const;

trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp

@@ -2768 +2768 @@
             cache->postNotification(renderParent, AXObjectCache::AXLiveRegionChanged);
 
-        if (parent->isARIATextControl() && !parent->isNativeTextControl() && !parent->node()->hasEditableStyle())
+        if ((parent->isARIATextControl() || parent->hasContentEditableAttributeSet()) && !parent->isNativeTextControl())
             cache->postNotification(renderParent, AXObjectCache::AXValueChanged);
     }