Changeset 168420 in webkit


Ignore:
Timestamp:
May 7, 2014 3:54:29 AM (10 years ago)
Author:
calvaris@igalia.com
Message:

[GStreamer] Corrected typo
https://bugs.webkit.org/show_bug.cgi?id=132609

Reviewed by Martin Robinson.

Corrected m_canFallBackToLastFinishedSeekPositon typo and
initialized in the constructor to prevent problems in the future.

No test needed.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
Initialized m_canFallBackToLastFinishedSeekPosition as false.
(WebCore::MediaPlayerPrivateGStreamer::playbackPosition):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
(WebCore::MediaPlayerPrivateGStreamer::asyncStateChangeDone):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

m_canFallBackToLastFinishedSeekPositon ->
m_canFallBackToLastFinishedSeekPosition

Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r168418 r168420  
     12014-05-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
     2
     3        [GStreamer] Corrected typo
     4        https://bugs.webkit.org/show_bug.cgi?id=132609
     5
     6        Reviewed by Martin Robinson.
     7
     8        Corrected m_canFallBackToLastFinishedSeekPositon typo and
     9        initialized in the constructor to prevent problems in the future.
     10
     11        No test needed.
     12
     13        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
     14        (WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
     15        Initialized m_canFallBackToLastFinishedSeekPosition as false.
     16        (WebCore::MediaPlayerPrivateGStreamer::playbackPosition):
     17        (WebCore::MediaPlayerPrivateGStreamer::handleMessage):
     18        (WebCore::MediaPlayerPrivateGStreamer::asyncStateChangeDone):
     19        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
     20        m_canFallBackToLastFinishedSeekPositon ->
     21        m_canFallBackToLastFinishedSeekPosition
     22
    1232014-05-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
    224
  • trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

    r167193 r168420  
    205205    , m_seekIsPending(false)
    206206    , m_timeOfOverlappingSeek(-1)
     207    , m_canFallBackToLastFinishedSeekPosition(false)
    207208    , m_buffering(false)
    208209    , m_playbackRate(1)
     
    360361    if (static_cast<GstClockTime>(position) != GST_CLOCK_TIME_NONE)
    361362        result = static_cast<double>(position) / GST_SECOND;
    362     else if (m_canFallBackToLastFinishedSeekPositon)
     363    else if (m_canFallBackToLastFinishedSeekPosition)
    363364        result = m_seekTime;
    364365
     
    878879    GstState requestedState, currentState;
    879880
    880     m_canFallBackToLastFinishedSeekPositon = false;
     881    m_canFallBackToLastFinishedSeekPosition = false;
    881882
    882883    if (structure) {
     
    13051306            // The pipeline can still have a pending state. In this case a position query will fail.
    13061307            // Right now we can use m_seekTime as a fallback.
    1307             m_canFallBackToLastFinishedSeekPositon = true;
     1308            m_canFallBackToLastFinishedSeekPosition = true;
    13081309            timeChanged();
    13091310        }
  • trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h

    r167193 r168420  
    181181    bool m_seekIsPending;
    182182    float m_timeOfOverlappingSeek;
    183     bool m_canFallBackToLastFinishedSeekPositon;
     183    bool m_canFallBackToLastFinishedSeekPosition;
    184184    bool m_buffering;
    185185    float m_playbackRate;
Note: See TracChangeset for help on using the changeset viewer.