Changeset 168465 in webkit

Timestamp:

May 8, 2014 1:16:31 AM (10 years ago)

Author:

commit-queue@webkit.org

Message:

[CSS Blending] Changing isolation CSS property should not trigger repaint in RenderStyle::changeRequiresLayerRepaint
​https://bugs.webkit.org/show_bug.cgi?id=131436

Patch by Ion Rosca <Ion Rosca> on 2014-05-08
Reviewed by Dirk Schulze.

Source/WebCore:
The isolation:isolate property will create a stacking context. This is done in
StyleResolver::adjustRenderStyle where z-index is forced to 0.
If the element is already a stacking context for any other reason,
changing the isolation flag should not have any effect.

Tests: css3/blending/repaint/blend-mode-turn-off-isolation-no-effect.html

css3/blending/repaint/blend-mode-turn-off-isolation.html

• rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::changeRequiresLayerRepaint):
do not request repaint if isolation has changed.

LayoutTests:

• css3/blending/repaint/blend-mode-turn-off-isolation-expected.txt: Added.
• css3/blending/repaint/blend-mode-turn-off-isolation-no-effect-expected.txt: Added.
• css3/blending/repaint/blend-mode-turn-off-isolation-no-effect.html: Added.
• css3/blending/repaint/blend-mode-turn-off-isolation.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/css3/blending/repaint/blend-mode-turn-off-isolation-expected.txt (added)
• LayoutTests/css3/blending/repaint/blend-mode-turn-off-isolation-no-effect-expected.txt (added)
• LayoutTests/css3/blending/repaint/blend-mode-turn-off-isolation-no-effect.html (added)
• LayoutTests/css3/blending/repaint/blend-mode-turn-off-isolation.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/style/RenderStyle.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-05-08  Ion Rosca  <rosca@adobe.com>
+
+        [CSS Blending] Changing isolation CSS property should not trigger repaint in RenderStyle::changeRequiresLayerRepaint
+        https://bugs.webkit.org/show_bug.cgi?id=131436
+
+        Reviewed by Dirk Schulze.
+
+        * css3/blending/repaint/blend-mode-turn-off-isolation-expected.txt: Added.
+        * css3/blending/repaint/blend-mode-turn-off-isolation-no-effect-expected.txt: Added.
+        * css3/blending/repaint/blend-mode-turn-off-isolation-no-effect.html: Added.
+        * css3/blending/repaint/blend-mode-turn-off-isolation.html: Added.
+
 2014-05-08  Manuel Rego Casasnovas  <rego@igalia.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-05-08  Ion Rosca  <rosca@adobe.com>
+
+        [CSS Blending] Changing isolation CSS property should not trigger repaint in RenderStyle::changeRequiresLayerRepaint
+        https://bugs.webkit.org/show_bug.cgi?id=131436
+
+        Reviewed by Dirk Schulze.
+
+        The isolation:isolate property will create a stacking context. This is done in
+        StyleResolver::adjustRenderStyle where z-index is forced to 0.
+        If the element is already a stacking context for any other reason,
+        changing the isolation flag should not have any effect.
+
+        Tests: css3/blending/repaint/blend-mode-turn-off-isolation-no-effect.html
+               css3/blending/repaint/blend-mode-turn-off-isolation.html
+
+        * rendering/style/RenderStyle.cpp:
+        (WebCore::RenderStyle::changeRequiresLayerRepaint):
+        do not request repaint if isolation has changed.
+
 2014-05-08  Manuel Rego Casasnovas  <rego@igalia.com>
 

trunk/Source/WebCore/rendering/style/RenderStyle.cpp

@@ -664 +664 @@
     if (rareNonInheritedData->m_effectiveBlendMode != other->rareNonInheritedData->m_effectiveBlendMode)
         return true;
-
-    if (rareNonInheritedData->m_isolation != other->rareNonInheritedData->m_isolation)
-        return true;
 #endif