Changeset 16881 in webkit


Ignore:
Timestamp:
Oct 7, 2006 5:39:48 AM (17 years ago)
Author:
bdash
Message:

2006-10-07 Andrew Wellington <proton@wiretapped.net>

Reviewed by Eric.

Bug 10837: REGRESSION: Yahoo New Charts Crashes WebKit
http://bugzilla.opendarwin.org/show_bug.cgi?id=10837

Return null when there is no frame. This matches Firefox.

  • bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::getValueProperty):

2006-10-07 Andrew Wellington <proton@wiretapped.net>

Reviewed by Eric.

Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10837
Bug 10837: REGRESSION: Yahoo New Charts Crashes WebKit

  • fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.checksum: Added.
  • fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.png: Added.
  • fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.txt: Added.
  • fast/dom/HTMLDocument/frameless-location-bugzilla10837.html: Added.
Location:
trunk
Files:
4 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r16807 r16881  
     12006-10-07  Andrew Wellington  <proton@wiretapped.net>
     2
     3        Reviewed by Eric.
     4
     5        Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10837
     6        Bug 10837: REGRESSION: Yahoo New Charts Crashes WebKit
     7
     8        * fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.checksum: Added.
     9        * fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.png: Added.
     10        * fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.txt: Added.
     11        * fast/dom/HTMLDocument/frameless-location-bugzilla10837.html: Added.
     12
    1132006-10-05  Alexey Proskuryakov  <ap@nypop.com>
    214
  • trunk/WebCore/ChangeLog

    r16879 r16881  
     12006-10-07  Andrew Wellington  <proton@wiretapped.net>
     2
     3        Reviewed by Eric.
     4
     5        Bug 10837: REGRESSION: Yahoo New Charts Crashes WebKit
     6        http://bugzilla.opendarwin.org/show_bug.cgi?id=10837
     7
     8        Return null when there is no frame. This matches Firefox.
     9
     10        * bindings/js/kjs_html.cpp:
     11        (KJS::JSHTMLDocument::getValueProperty):
     12
    1132006-10-07  David Hyatt  <hyatt@apple.com>
    214
  • trunk/WebCore/bindings/js/kjs_html.cpp

    r15828 r16881  
    252252    return toJS(exec, body);
    253253  case Location:
     254    if (!frame)
     255      return jsNull();
    254256    if (Window* win = Window::retrieveWindow(frame))
    255257      return win->location();
Note: See TracChangeset for help on using the changeset viewer.