Changeset 169019 in webkit

Timestamp:

May 18, 2014 3:03:07 PM (10 years ago)

Author:

mjs@apple.com

Message:

REGRESSION (r156546): Default media controls are laid out incorrectly when media element is styled with direction:rtl
​https://bugs.webkit.org/show_bug.cgi?id=132531
<rdar://problem/16806267>

Source/WebCore:

Reviewed by Mark Rowe.

This was already tested by the media/video-rtl.htm reftest, now unskipped.

• Modules/mediacontrols/mediaControlsApple.css:

(audio::-webkit-media-controls-panel): Add missing direction: ltr

LayoutTests:

Reviewed by Mark Rowe.

• platform/mac/TestExpectations: Unskip media/video-rtl.html

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/mediacontrols/mediaControlsApple.css (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-05-18  Maciej Stachowiak  <mjs@apple.com>
+
+        REGRESSION (r156546): Default media controls are laid out incorrectly when media element is styled with direction:rtl
+        https://bugs.webkit.org/show_bug.cgi?id=132531
+        <rdar://problem/16806267>
+
+        Reviewed by Mark Rowe.
+
+        * platform/mac/TestExpectations: Unskip media/video-rtl.html
+
 2014-05-18  Rik Cabanier  <cabanier@adobe.com>
 

trunk/LayoutTests/platform/mac/TestExpectations

@@ -1170 +1170 @@
 webkit.org/b/122021 media/video-display-toggle.html
 webkit.org/b/122021 media/video-empty-source.html
-webkit.org/b/122021 media/video-rtl.html
 webkit.org/b/122021 media/video-volume-slider.html
 webkit.org/b/122021 media/volume-bar-empty-when-muted.html

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-05-18  Maciej Stachowiak  <mjs@apple.com>
+
+        REGRESSION (r156546): Default media controls are laid out incorrectly when media element is styled with direction:rtl
+        https://bugs.webkit.org/show_bug.cgi?id=132531
+        <rdar://problem/16806267>
+        
+        Reviewed by Mark Rowe.
+
+        This was already tested by the media/video-rtl.htm reftest, now unskipped.
+
+        * Modules/mediacontrols/mediaControlsApple.css:
+        (audio::-webkit-media-controls-panel): Add missing direction: ltr
+
 2014-05-18  Rik Cabanier  <cabanier@adobe.com>
 

trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.css

@@ -95 +95 @@
     -webkit-user-select: none;
 
+    direction: ltr;
+
     transition: opacity 0.25s linear;
 }