Changeset 169065 in webkit

Timestamp:

May 19, 2014 2:09:01 PM (10 years ago)

Author:

Beth Dakin

Message:

Scrollbars display incorrectly after switching between fast and slow scrolling
mode, affects Find and real sites
​https://bugs.webkit.org/show_bug.cgi?id=133077
-and corresponding-
<rdar://problem/16888608>

Reviewed by Tim Horton.

We should always return true here when updating on the secondary thread is
supported. It does not need to be gated on whether we are actively taking
advantage of that support at this moment.

• platform/Scrollbar.cpp:

(WebCore::Scrollbar::supportsUpdateOnSecondaryThread):

Always update the presentationValue whenever we update the doubleValue just to
keep them in sync.

• platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::setPaintCharacteristicsForScrollbar):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/Scrollbar.cpp (modified) (1 diff)
• platform/mac/ScrollbarThemeMac.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-05-19  Beth Dakin  <bdakin@apple.com>
+
+        Scrollbars display incorrectly after switching between fast and slow scrolling 
+        mode, affects Find and real sites
+        https://bugs.webkit.org/show_bug.cgi?id=133077
+        -and corresponding-
+        <rdar://problem/16888608>
+
+        Reviewed by Tim Horton.
+
+        We should always return true here when updating on the secondary thread is 
+        supported. It does not need to be gated on whether we are actively taking 
+        advantage of that support at this moment.
+        * platform/Scrollbar.cpp:
+        (WebCore::Scrollbar::supportsUpdateOnSecondaryThread):
+
+        Always update the presentationValue whenever we update the doubleValue just to 
+        keep them in sync.
+        * platform/mac/ScrollbarThemeMac.mm:
+        (WebCore::ScrollbarThemeMac::setPaintCharacteristicsForScrollbar):
+
 2014-05-19  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/platform/Scrollbar.cpp

@@ -551 +551 @@
     // the necessary support within AppKit.
 #if ENABLE(ASYNC_SCROLLING) && PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000
-    return m_scrollableArea ? !m_scrollableArea->updatesScrollLayerPositionOnMainThread() : false;
+    return true;
 #else
     return false;

trunk/Source/WebCore/platform/mac/ScrollbarThemeMac.mm

@@ -480 +480 @@
     [painter setBoundsSize:scrollbar->frameRect().size()];
     [painter setDoubleValue:value];
+    [painter setPresentationValue:value];
     [painter setKnobProportion:proportion];
     END_BLOCK_OBJC_EXCEPTIONS;