Changeset 169118 in webkit

Timestamp:

May 20, 2014 10:13:35 AM (10 years ago)

Author:

commit-queue@webkit.org

Message:

Only set title on SVG documents
​https://bugs.webkit.org/show_bug.cgi?id=133068

Patch by Prashant Hiremath <​hiremathprashants@gmail.com> on 2014-05-20
Reviewed by Dirk Schulze.

Source/WebCore:
Test: svg/custom/html_document_set_title.html

• svg/SVGTitleElement.cpp:

(WebCore::SVGTitleElement::insertedInto):
(WebCore::SVGTitleElement::removedFrom):
(WebCore::SVGTitleElement::childrenChanged):

LayoutTests:

• svg/custom/html_document_set_title-expected.txt: Added.
• svg/custom/html_document_set_title.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/svg/custom/html_document_set_title-expected.txt (added)
• LayoutTests/svg/custom/html_document_set_title.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/svg/SVGTitleElement.cpp (modified) (3 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-05-20  Prashant Hiremath  <hiremathprashants@gmail.com>
+
+        Only set title on SVG documents
+        https://bugs.webkit.org/show_bug.cgi?id=133068
+
+        Reviewed by Dirk Schulze.
+
+        * svg/custom/html_document_set_title-expected.txt: Added.
+        * svg/custom/html_document_set_title.html: Added.
+
 2014-05-20  Alexey Proskuryakov  <ap@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-05-20  Prashant Hiremath  <hiremathprashants@gmail.com>
+
+        Only set title on SVG documents
+        https://bugs.webkit.org/show_bug.cgi?id=133068
+
+        Reviewed by Dirk Schulze.
+
+        Test: svg/custom/html_document_set_title.html
+
+        * svg/SVGTitleElement.cpp:
+        (WebCore::SVGTitleElement::insertedInto):
+        (WebCore::SVGTitleElement::removedFrom):
+        (WebCore::SVGTitleElement::childrenChanged):
+
 2014-05-20  peavo@outlook.com  <peavo@outlook.com>
 

trunk/Source/WebCore/svg/SVGTitleElement.cpp

@@ -43 +43 @@
     if (!rootParent.inDocument())
         return InsertionDone;
-    // FIXME: It's possible to register SVGTitleElement to an HTMLDocument.
-    if (firstChild())
+
+    if (firstChild() && document().isSVGDocument()) {
         // FIXME: does SVG have a title text direction?
         document().setTitleElement(StringWithDirection(textContent(), LTR), this);
+    }
     return InsertionDone;
 }
@@ -53 +54 @@
 {
     SVGElement::removedFrom(rootParent);
-    if (rootParent.inDocument())
+    if (rootParent.inDocument() && document().isSVGDocument())
         document().removeTitle(this);
 }
@@ -60 +61 @@
 {
     SVGElement::childrenChanged(change);
-    if (inDocument())
+    if (inDocument() && document().isSVGDocument()) {
         // FIXME: does SVG have title text direction?
         document().setTitleElement(StringWithDirection(textContent(), LTR), this);
+    }
 }