Changeset 169120 in webkit

Timestamp:

May 20, 2014 10:38:04 AM (10 years ago)

Author:

stavila@adobe.com

Message:

REGRESSION: [CSS Regions] Content flowed directly into the flow thread that ends up in the second region is not properly repainted
​https://bugs.webkit.org/show_bug.cgi?id=133111

Reviewed by David Hyatt.

Source/WebCore:
When computing the repaint rect of an element flowed into a flow thread, if the element is flowed directly into
the flow thread (meaning its containing block is the flow thread itself), the region's position within the flow
must no longer be taken into consideration, because its already included in the element's |topLeft|.

Test: fast/regions/hover-element-flowed-second-region.html

• rendering/RenderBox.cpp:

(WebCore::RenderBox::computeRectForRepaint):

LayoutTests:
Added test for the correct repaint of an element flowed directly into the second region of a flow thread.

• fast/regions/hover-element-flowed-second-region-expected.html: Added.
• fast/regions/hover-element-flowed-second-region.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/regions/hover-element-flowed-second-region-expected.html (added)
• LayoutTests/fast/regions/hover-element-flowed-second-region.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderBox.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-05-20  Radu Stavila  <stavila@adobe.com>
+
+        REGRESSION: [CSS Regions] Content flowed directly into the flow thread that ends up in the second region is not properly repainted
+        https://bugs.webkit.org/show_bug.cgi?id=133111
+
+        Reviewed by David Hyatt.
+
+        Added test for the correct repaint of an element flowed directly into the second region of a flow thread.
+
+        * fast/regions/hover-element-flowed-second-region-expected.html: Added.
+        * fast/regions/hover-element-flowed-second-region.html: Added.
+
 2014-05-20  Prashant Hiremath  <hiremathprashants@gmail.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-05-20  Radu Stavila  <stavila@adobe.com>
+
+        REGRESSION: [CSS Regions] Content flowed directly into the flow thread that ends up in the second region is not properly repainted
+        https://bugs.webkit.org/show_bug.cgi?id=133111
+
+        Reviewed by David Hyatt.
+
+        When computing the repaint rect of an element flowed into a flow thread, if the element is flowed directly into
+        the flow thread (meaning its containing block is the flow thread itself), the region's position within the flow
+        must no longer be taken into consideration, because its already included in the element's |topLeft|.
+
+        Test: fast/regions/hover-element-flowed-second-region.html
+
+        * rendering/RenderBox.cpp:
+        (WebCore::RenderBox::computeRectForRepaint):
+
 2014-05-20  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebCore/rendering/RenderBox.cpp

@@ -2141 +2141 @@
     // the regions so adding this here and then adding the topLeft again would cause
     // us to add the height twice.
-    if (o->isOutOfFlowRenderFlowThread() && position != AbsolutePosition) {
+    // The same logic applies for elements flowed directly into the flow thread. Their topLeft member
+    // will already contain the portion rect of the region.
+    if (o->isOutOfFlowRenderFlowThread() && position != AbsolutePosition && containingBlock() != flowThreadContainingBlock()) {
         RenderRegion* firstRegion = nullptr;
         RenderRegion* lastRegion = nullptr;