Changeset 169350 in webkit

Timestamp:

May 26, 2014 9:37:59 AM (10 years ago)

Author:

Carlos Garcia Campos

Message:

REGRESSION(r164632): [GTK] Crash in generate-gtkdoc when rebasing docs
​https://bugs.webkit.org/show_bug.cgi?id=133279

Reviewed by Philippe Normand.

generator.saw_warnings is only set by GTKDoc::generate(), so it
should only be used after generate.

• gtk/generate-gtkdoc:

(generate_documentation_for_config): Do not check
generator.saw_warnings again, simply return the value returned by
generate_doc() which is generator.saw_warnings. When rebasing,
returns always False since there aren't warnings.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• gtk/generate-gtkdoc (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2014-05-26  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        REGRESSION(r164632): [GTK] Crash in generate-gtkdoc when rebasing docs
+        https://bugs.webkit.org/show_bug.cgi?id=133279
+
+        Reviewed by Philippe Normand.
+
+        generator.saw_warnings is only set by GTKDoc::generate(), so it
+        should only be used after generate.
+
+        * gtk/generate-gtkdoc:
+        (generate_documentation_for_config): Do not check
+        generator.saw_warnings again, simply return the value returned by
+        generate_doc() which is generator.saw_warnings. When rebasing,
+        returns always False since there aren't warnings.
+
 2014-05-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 

trunk/Tools/gtk/generate-gtkdoc

@@ -150 +150 @@
 
     if not arguments.rebase:
-        generate_doc(generator, arguments.skip_html)
-    else:
-        rebase_doc(generator)
-    return generator.saw_warnings
+        return generate_doc(generator, arguments.skip_html)
+
+    rebase_doc(generator)
+    return False
 
 def prepare_environment_for_gtkdoc_generation():