Changeset 169710 in webkit

Timestamp:

Jun 9, 2014 1:39:17 PM (10 years ago)

Author:

dbates@webkit.org

Message:

[iOS] Amazon app: Cannot interact with product page after tapping on product image
​https://bugs.webkit.org/show_bug.cgi?id=133559
<rdar://problem/16332749>

Reviewed by Oliver Hunt.

Source/WebCore:
As a workaround for issues in the Amazon app, mark the attribute navigator.geolocation as
replaceable so that we don't throw a JavaScript type error when assigning to an instance
attribute that shadows it. At the time of writing the first such assignment to is ignored.
See <​https://bugs.webkit.org/show_bug.cgi?id=133648> for more details.

When loading a product page in the Amazon app it overwrites the readonly property geolocation
on an object that extends the Navigator object. In strict mode, this operation is not honored
and is treated as a JavaScript type error, which stops JavaScript execution. Therefore, the
product page does not behave as intended. In contrast, this operation would not be honored in
non-strict mode and would not be treated as a JavaScript type error.

Test: js/dom/shadow-navigator-geolocation-in-strict-mode-does-not-throw.html

• Modules/geolocation/NavigatorGeolocation.idl:

LayoutTests:
Add a test to ensure that assigning to an instance attribute in strict mode that shadows
navigator.geolocation doesn't cause a JavaScript type error.

• js/dom/script-tests/shadow-navigator-geolocation-in-strict-mode-does-not-throw.js: Added.

(createObjectWithPrototype.F):
(createObjectWithPrototype):

• js/dom/shadow-navigator-geolocation-in-strict-mode-does-not-throw-expected.txt: Added.
• js/dom/shadow-navigator-geolocation-in-strict-mode-does-not-throw.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/js/dom/script-tests/shadow-navigator-geolocation-in-strict-mode-does-not-throw.js (added)
• LayoutTests/js/dom/shadow-navigator-geolocation-in-strict-mode-does-not-throw-expected.txt (added)
• LayoutTests/js/dom/shadow-navigator-geolocation-in-strict-mode-does-not-throw.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/geolocation/NavigatorGeolocation.idl (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-06-09  Daniel Bates  <dabates@apple.com>
+
+        [iOS] Amazon app: Cannot interact with product page after tapping on product image
+        https://bugs.webkit.org/show_bug.cgi?id=133559
+        <rdar://problem/16332749>
+
+        Reviewed by Oliver Hunt.
+
+        Add a test to ensure that assigning to an instance attribute in strict mode that shadows
+        navigator.geolocation doesn't cause a JavaScript type error.
+
+        * js/dom/script-tests/shadow-navigator-geolocation-in-strict-mode-does-not-throw.js: Added.
+        (createObjectWithPrototype.F):
+        (createObjectWithPrototype):
+        * js/dom/shadow-navigator-geolocation-in-strict-mode-does-not-throw-expected.txt: Added.
+        * js/dom/shadow-navigator-geolocation-in-strict-mode-does-not-throw.html: Added.
+
 2014-06-05  Mark Hahnenberg  <mhahnenberg@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-06-09  Daniel Bates  <dabates@apple.com>
+
+        [iOS] Amazon app: Cannot interact with product page after tapping on product image
+        https://bugs.webkit.org/show_bug.cgi?id=133559
+        <rdar://problem/16332749>
+
+        Reviewed by Oliver Hunt.
+
+        As a workaround for issues in the Amazon app, mark the attribute navigator.geolocation as
+        replaceable so that we don't throw a JavaScript type error when assigning to an instance
+        attribute that shadows it. At the time of writing the first such assignment to is ignored.
+        See <https://bugs.webkit.org/show_bug.cgi?id=133648> for more details.
+
+        When loading a product page in the Amazon app it overwrites the readonly property geolocation
+        on an object that extends the Navigator object. In strict mode, this operation is not honored
+        and is treated as a JavaScript type error, which stops JavaScript execution. Therefore, the
+        product page does not behave as intended. In contrast, this operation would not be honored in
+        non-strict mode and would not be treated as a JavaScript type error.
+
+        Test: js/dom/shadow-navigator-geolocation-in-strict-mode-does-not-throw.html
+
+        * Modules/geolocation/NavigatorGeolocation.idl:
+
 2014-06-09  Andreas Kling  <akling@apple.com>
 

trunk/Source/WebCore/Modules/geolocation/NavigatorGeolocation.idl

@@ -21 +21 @@
     Conditional=GEOLOCATION,
 ] partial interface Navigator {
-    readonly attribute Geolocation geolocation;
+    // FIXME: We should consider making this attribute replaceable only to the
+    // Amazon app on iOS.
+    [Replaceable] readonly attribute Geolocation geolocation;
 };