Changeset 170045 in webkit

Timestamp:

Jun 16, 2014 10:35:42 PM (10 years ago)

Author:

mihnea@adobe.com

Message:

[CSSRegions] Region with border radius and overflow:hidden does not clip content
​https://bugs.webkit.org/show_bug.cgi?id=133476

Reviewed by Andrei Bucur.

Source/WebCore:
When setting the clip before painting the named flow content,
use the region's foreground rect to take the region's border radius
into account if needed.

Test: fast/regions/region-border-radius-overflow-clip.html

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintFlowThreadIfRegionForFragments):

LayoutTests:

• fast/regions/region-border-radius-overflow-clip-expected.html: Added.
• fast/regions/region-border-radius-overflow-clip.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/regions/region-border-radius-overflow-clip-expected.html (added)
• LayoutTests/fast/regions/region-border-radius-overflow-clip.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderLayer.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-06-16  Mihnea Ovidenie  <mihnea@adobe.com>
+
+        [CSSRegions] Region with border radius and overflow:hidden does not clip content
+        https://bugs.webkit.org/show_bug.cgi?id=133476
+
+        Reviewed by Andrei Bucur.
+
+        * fast/regions/region-border-radius-overflow-clip-expected.html: Added.
+        * fast/regions/region-border-radius-overflow-clip.html: Added.
+
 2014-06-12  Mark Lam  <mark.lam@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-06-16  Mihnea Ovidenie  <mihnea@adobe.com>
+
+        [CSSRegions] Region with border radius and overflow:hidden does not clip content
+        https://bugs.webkit.org/show_bug.cgi?id=133476
+
+        Reviewed by Andrei Bucur.
+
+        When setting the clip before painting the named flow content,
+        use the region's foreground rect to take the region's border radius
+        into account if needed.
+
+        Test: fast/regions/region-border-radius-overflow-clip.html
+
+        * rendering/RenderLayer.cpp:
+        (WebCore::RenderLayer::paintFlowThreadIfRegionForFragments):
+
 2014-06-16  Sam Weinig  <sam@webkit.org>
 

trunk/Source/WebCore/rendering/RenderLayer.cpp

@@ -6745 +6745 @@
         const LayerFragment& fragment = fragments.at(i);
 
-        ClipRect clipRect = fragment.backgroundRect;
+        ClipRect clipRect = fragment.foregroundRect;
         if (flowFragment->shouldClipFlowThreadContent())
             clipRect.intersect(regionClipRect);