Changeset 170117 in webkit

Timestamp:

Jun 18, 2014 2:41:44 PM (10 years ago)

Author:

ddkilzer@apple.com

Message:

-[JSContext setName:] leaks NSString
<​http://webkit.org/b/134038>

Reviewed by Joseph Pecoraro.

Fixes the following static analyzer warning:

JavaScriptCore/API/JSContext.mm:200:73: warning: Potential leak of an object

JSStringRef nameJS = name ? JSStringCreateWithCFString((CFStringRef)[name copy]) : nullptr;

• API/JSContext.mm:

(-[JSContext setName:]): Autorelease the copy of |name|.

Location:

trunk/Source/JavaScriptCore

Files:

• API/JSContext.mm (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Source/JavaScriptCore/API/JSContext.mm

@@ -198 +198 @@
 - (void)setName:(NSString *)name
 {
-    JSStringRef nameJS = name ? JSStringCreateWithCFString((CFStringRef)[name copy]) : nullptr;
+    JSStringRef nameJS = name ? JSStringCreateWithCFString((CFStringRef)[[name copy] autorelease]) : nullptr;
     JSGlobalContextSetName(m_context, nameJS);
     if (nameJS)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2014-06-18  David Kilzer  <ddkilzer@apple.com>
+
+        -[JSContext setName:] leaks NSString
+        <http://webkit.org/b/134038>
+
+        Reviewed by Joseph Pecoraro.
+
+        Fixes the following static analyzer warning:
+
+            JavaScriptCore/API/JSContext.mm:200:73: warning: Potential leak of an object
+                JSStringRef nameJS = name ? JSStringCreateWithCFString((CFStringRef)[name copy]) : nullptr;
+                                                                                    ^
+
+        * API/JSContext.mm:
+        (-[JSContext setName:]): Autorelease the copy of |name|.
+
 2014-06-18  Mark Lam  <mark.lam@apple.com>