Changeset 170359 in webkit
- Timestamp:
- Jun 24, 2014 4:09:22 AM (10 years ago)
- Location:
- trunk
- Files:
-
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r170354 r170359 1 2014-06-24 Jarek Czekalski <jarekczek@poczta.onet.pl> 2 3 [ATK] Extended the test for accessibility of text inside "span" block in "a" block 4 with the tests for caret movements in these cases. 5 https://bugs.webkit.org/show_bug.cgi?id=130941 6 7 Reviewed by Mario Sanchez Prada. 8 9 * platform/gtk/accessibility/text-in-span-block-in-a-block-expected.txt: 10 * platform/gtk/accessibility/text-in-span-block-in-a-block.html: 11 Added testing for text-caret-moved signal. Added one more "a" element to the set. 12 1 13 2014-06-24 Michał Pakuła vel Rutka <m.pakula@samsung.com> 2 14 -
trunk/LayoutTests/platform/gtk/accessibility/text-in-span-block-in-a-block-expected.txt
r169936 r170359 11 11 before, 12 12 six 13 no span here 13 14 This tests that text inside "a" block inside "span" block is accessible. 14 15 … … 18 19 PASS accText is "AXValue:one" 19 20 PASS setCaretOffset(elem, 1) is true 21 PASS caretMovedData is "Link|1" 20 22 PASS accText is "AXValue:two" 21 23 PASS setCaretOffset(elem, 1) is true 24 PASS caretMovedData is "Link|1" 22 25 PASS accText is "AXValue:three" 23 26 PASS setCaretOffset(elem, 1) is true 27 PASS caretMovedData is "Link|1" 24 28 PASS accText is "AXValue:before,four,after" 25 29 PASS setCaretOffset(elem, 1) is true 30 PASS caretMovedData is "Link|1" 26 31 PASS accText is "AXValue:five,after" 27 32 PASS setCaretOffset(elem, 1) is true 33 PASS caretMovedData is "Link|1" 28 34 PASS accText is "AXValue:before,six" 29 35 PASS setCaretOffset(elem, 1) is true 36 PASS caretMovedData is "Link|1" 37 PASS accText is "AXValue:nospanhere" 38 PASS setCaretOffset(elem, 1) is true 39 PASS caretMovedData is "Link|1" 30 40 PASS successfullyParsed is true 31 41 -
trunk/LayoutTests/platform/gtk/accessibility/text-in-span-block-in-a-block.html
r169936 r170359 42 42 <a id="id6" href="x" style="display:block;">before,<span style="display:block;">six</span></a> 43 43 44 <a id="id7" href="x" style="display:block;">no span here</a> 45 44 46 <div id="console"></div> 45 47 … … 73 75 var i, linkText, accText, id; 74 76 accessibilityController.addNotificationListener(globalListener) 75 for (i = 1; i <= 6; i++) {77 for (i = 1; i <= 7; i++) { 76 78 id = 'id' + i; 77 79 elem = accessibilityController.accessibleElementById(id); … … 81 83 caretMovedData = ''; 82 84 shouldBe("setCaretOffset(elem, 1)", "true"); 83 // FIXME: This line will be added after fixing bug #130941. 84 //shouldBeEqualToString("caretMovedData", "Link|1"); 85 shouldBeEqualToString("caretMovedData", "Link|1"); 85 86 } 86 87 } -
trunk/Source/WebCore/ChangeLog
r170355 r170359 1 2014-06-24 Jarek Czekalski <jarekczek@poczta.onet.pl> 2 3 [ATK] Don't ignore links rendered as blocks. 4 https://bugs.webkit.org/show_bug.cgi?id=130941 5 6 Reviewed by Mario Sanchez Prada. 7 8 * /m/usr/src/webkit-trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp: 9 (WebCore::AccessibilityObject::objectFocusedAndCaretOffsetUnignored): Don't ignore links 10 when they are renderered with display:block. 11 1 12 2014-06-24 Carlos Garcia Campos <cgarcia@igalia.com> 2 13 -
trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp
r170342 r170359 1318 1318 return 0; 1319 1319 1320 // Don't ignore links if the offset is being requested for a link. 1321 if (!referenceObject->isLink() && firstUnignoredParent->isLink()) 1320 // Don't ignore links if the offset is being requested for a link 1321 // or if the link is a block. 1322 if (!referenceObject->isLink() && firstUnignoredParent->isLink() 1323 && !(firstUnignoredParent->renderer() && !firstUnignoredParent->renderer()->isInline())) 1322 1324 firstUnignoredParent = firstUnignoredParent->parentObjectUnignored(); 1323 1325 if (!firstUnignoredParent)
Note: See TracChangeset
for help on using the changeset viewer.