Changeset 170359 in webkit


Ignore:
Timestamp:
Jun 24, 2014 4:09:22 AM (10 years ago)
Author:
commit-queue@webkit.org
Message:

Source/WebCore: [ATK] Don't ignore links rendered as blocks.
https://bugs.webkit.org/show_bug.cgi?id=130941

Patch by Jarek Czekalski <Jarek Czekalski> on 2014-06-24
Reviewed by Mario Sanchez Prada.

  • /m/usr/src/webkit-trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(WebCore::AccessibilityObject::objectFocusedAndCaretOffsetUnignored): Don't ignore links
when they are renderered with display:block.

LayoutTests: [ATK] Extended the test for accessibility of text inside "span" block in "a" block
with the tests for caret movements in these cases.
https://bugs.webkit.org/show_bug.cgi?id=130941

Patch by Jarek Czekalski <Jarek Czekalski> on 2014-06-24
Reviewed by Mario Sanchez Prada.

  • platform/gtk/accessibility/text-in-span-block-in-a-block-expected.txt:
  • platform/gtk/accessibility/text-in-span-block-in-a-block.html:

Added testing for text-caret-moved signal. Added one more "a" element to the set.

Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r170354 r170359  
     12014-06-24  Jarek Czekalski  <jarekczek@poczta.onet.pl>
     2
     3        [ATK] Extended the test for accessibility of text inside "span" block in "a" block
     4        with the tests for caret movements in these cases.
     5        https://bugs.webkit.org/show_bug.cgi?id=130941
     6
     7        Reviewed by Mario Sanchez Prada.
     8
     9        * platform/gtk/accessibility/text-in-span-block-in-a-block-expected.txt:
     10        * platform/gtk/accessibility/text-in-span-block-in-a-block.html:
     11        Added testing for text-caret-moved signal. Added one more "a" element to the set.
     12
    1132014-06-24  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
    214
  • trunk/LayoutTests/platform/gtk/accessibility/text-in-span-block-in-a-block-expected.txt

    r169936 r170359  
    1111before,
    1212six
     13no span here
    1314This tests that text inside "a" block inside "span" block is accessible.
    1415
     
    1819PASS accText is "AXValue:one"
    1920PASS setCaretOffset(elem, 1) is true
     21PASS caretMovedData is "Link|1"
    2022PASS accText is "AXValue:two"
    2123PASS setCaretOffset(elem, 1) is true
     24PASS caretMovedData is "Link|1"
    2225PASS accText is "AXValue:three"
    2326PASS setCaretOffset(elem, 1) is true
     27PASS caretMovedData is "Link|1"
    2428PASS accText is "AXValue:before,four,after"
    2529PASS setCaretOffset(elem, 1) is true
     30PASS caretMovedData is "Link|1"
    2631PASS accText is "AXValue:five,after"
    2732PASS setCaretOffset(elem, 1) is true
     33PASS caretMovedData is "Link|1"
    2834PASS accText is "AXValue:before,six"
    2935PASS setCaretOffset(elem, 1) is true
     36PASS caretMovedData is "Link|1"
     37PASS accText is "AXValue:nospanhere"
     38PASS setCaretOffset(elem, 1) is true
     39PASS caretMovedData is "Link|1"
    3040PASS successfullyParsed is true
    3141
  • trunk/LayoutTests/platform/gtk/accessibility/text-in-span-block-in-a-block.html

    r169936 r170359  
    4242<a id="id6" href="x" style="display:block;">before,<span style="display:block;">six</span></a>
    4343
     44<a id="id7" href="x" style="display:block;">no span here</a>
     45
    4446<div id="console"></div>
    4547
     
    7375    var i, linkText, accText, id;
    7476    accessibilityController.addNotificationListener(globalListener)
    75     for (i = 1; i <= 6; i++) {
     77    for (i = 1; i <= 7; i++) {
    7678        id = 'id' + i;
    7779        elem = accessibilityController.accessibleElementById(id);
     
    8183        caretMovedData = '';
    8284        shouldBe("setCaretOffset(elem, 1)", "true");
    83         // FIXME: This line will be added after fixing bug #130941.
    84         //shouldBeEqualToString("caretMovedData", "Link|1");
     85        shouldBeEqualToString("caretMovedData", "Link|1");
    8586    }
    8687}
  • trunk/Source/WebCore/ChangeLog

    r170355 r170359  
     12014-06-24  Jarek Czekalski  <jarekczek@poczta.onet.pl>
     2
     3        [ATK] Don't ignore links rendered as blocks.
     4        https://bugs.webkit.org/show_bug.cgi?id=130941
     5
     6        Reviewed by Mario Sanchez Prada.
     7
     8        * /m/usr/src/webkit-trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
     9        (WebCore::AccessibilityObject::objectFocusedAndCaretOffsetUnignored): Don't ignore links
     10        when they are renderered with display:block.
     11
    1122014-06-24  Carlos Garcia Campos  <cgarcia@igalia.com>
    213
  • trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp

    r170342 r170359  
    13181318        return 0;
    13191319
    1320     // Don't ignore links if the offset is being requested for a link.
    1321     if (!referenceObject->isLink() && firstUnignoredParent->isLink())
     1320    // Don't ignore links if the offset is being requested for a link
     1321    // or if the link is a block.
     1322    if (!referenceObject->isLink() && firstUnignoredParent->isLink()
     1323        && !(firstUnignoredParent->renderer() && !firstUnignoredParent->renderer()->isInline()))
    13221324        firstUnignoredParent = firstUnignoredParent->parentObjectUnignored();
    13231325    if (!firstUnignoredParent)
Note: See TracChangeset for help on using the changeset viewer.