Changeset 170389 in webkit


Ignore:
Timestamp:
Jun 24, 2014 1:59:51 PM (10 years ago)
Author:
jonowells@apple.com
Message:

Web Inspector: TypeError when hovering over "Show All Nodes" button in the Dom Tree inspector
https://bugs.webkit.org/show_bug.cgi?id=133699

Reviewed by Geoffrey Garen.

The call to element._createTooltipForNode() was failing because element was sometimes not a
DOMTreeOutline but rather only a TreeElement (in the case of the "Show All Nodes" button specifically).
A check for type fixes this issue.

  • UserInterface/Views/DOMTreeOutline.js:

(WebInspector.DOMTreeOutline.prototype._onmousemove): Check for presence of _createTooltipForNode.

Location:
trunk/Source/WebInspectorUI
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebInspectorUI/ChangeLog

    r170240 r170389  
     12014-06-24  Jono Wells  <jonowells@apple.com>
     2
     3        Web Inspector: TypeError when hovering over "Show All Nodes" button in the Dom Tree inspector
     4        https://bugs.webkit.org/show_bug.cgi?id=133699
     5
     6        Reviewed by Geoffrey Garen.
     7
     8        The call to element._createTooltipForNode() was failing because element was sometimes not a
     9        DOMTreeOutline but rather only a TreeElement (in the case of the "Show All Nodes" button specifically).
     10        A check for type fixes this issue.
     11
     12        * UserInterface/Views/DOMTreeOutline.js:
     13        (WebInspector.DOMTreeOutline.prototype._onmousemove): Check for presence of _createTooltipForNode.
     14
    1152014-06-21  Jono Wells  <jonowells@apple.com>
    216
  • trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js

    r168919 r170389  
    310310
    311311            // Lazily compute tag-specific tooltips.
    312             if (element.representedObject && !element.tooltip)
     312            if (element.representedObject && !element.tooltip && element._createTooltipForNode)
    313313                element._createTooltipForNode();
    314314        }
Note: See TracChangeset for help on using the changeset viewer.