Changeset 170480 in webkit


Ignore:
Timestamp:
Jun 26, 2014 8:30:23 AM (10 years ago)
Author:
ddkilzer@apple.com
Message:

DFG::FunctionWhitelist::parseFunctionNamesInFile does not close file
<http://webkit.org/b/134343>
<rdar://problem/17459487>

Reviewed by Michael Saboff.

  • dfg/DFGFunctionWhitelist.cpp:

(JSC::DFG::FunctionWhitelist::parseFunctionNamesInFile):
Close the file handle, and log an error on failure.

Location:
trunk/Source/JavaScriptCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/ChangeLog

    r170444 r170480  
     12014-06-26  David Kilzer  <ddkilzer@apple.com>
     2
     3        DFG::FunctionWhitelist::parseFunctionNamesInFile does not close file
     4        <http://webkit.org/b/134343>
     5        <rdar://problem/17459487>
     6
     7        Reviewed by Michael Saboff.
     8
     9        * dfg/DFGFunctionWhitelist.cpp:
     10        (JSC::DFG::FunctionWhitelist::parseFunctionNamesInFile):
     11        Close the file handle, and log an error on failure.
     12
    1132014-06-25  Dana Burkart  <dburkart@apple.com>
    214
  • trunk/Source/JavaScriptCore/dfg/DFGFunctionWhitelist.cpp

    r169518 r170480  
    8282        m_entries.add(String(line, length));
    8383    }
     84
     85    int result = fclose(f);
     86    if (result)
     87        dataLogF("Failed to close file %s: %s\n", filename, strerror(errno));
    8488}
    8589
Note: See TracChangeset for help on using the changeset viewer.