Changeset 171197 in webkit


Ignore:
Timestamp:
Jul 17, 2014 2:27:56 PM (10 years ago)
Author:
Brent Fulgham
Message:

[Mac] Full screen video not always animating in the correct Space
https://bugs.webkit.org/show_bug.cgi?id=135020
<rdar://problem/17542310>

Reviewed by Dean Jackson.

The fullscreen window can "remember" the Space it was part of the first time you enter fullscreen
mode. Subsequent fullscreen transitions will always start from this Space, even if you move
the WebKit-hosted application to a different Space.

We can help the display system know when we've moved to a new Space by calling NSWindow's
'orderBack' method on the fullscreen window prior to starting the transition to fullscreen mode.
This method call hooks the window into the current Space so everything works properly.

  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]): Add the
new fullscreen window to the current Space before starting transition to fullscreen.

Location:
trunk/Source/WebKit2
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit2/ChangeLog

    r171195 r171197  
     12014-07-17  Brent Fulgham  <bfulgham@apple.com>
     2
     3        [Mac] Full screen video not always animating in the correct Space
     4        https://bugs.webkit.org/show_bug.cgi?id=135020
     5        <rdar://problem/17542310>
     6
     7        Reviewed by Dean Jackson.
     8
     9       The fullscreen window can "remember" the Space it was part of the first time you enter fullscreen
     10       mode. Subsequent fullscreen transitions will always start from this Space, even if you move
     11       the WebKit-hosted application to a different Space.
     12
     13       We can help the display system know when we've moved to a new Space by calling NSWindow's
     14       'orderBack' method on the fullscreen window prior to starting the transition to fullscreen mode.
     15       This method call hooks the window into the current Space so everything works properly.
     16
     17        * UIProcess/mac/WKFullScreenWindowController.mm:
     18        (-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]): Add the
     19        new fullscreen window to the current Space before starting transition to fullscreen.
     20
    1212014-07-17  Timothy Hatcher  <timothy@apple.com>
    222
  • trunk/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm

    r169990 r171197  
    268268        _backgroundWindow = createBackgroundFullscreenWindow(NSZeroRect);
    269269
     270    [self.window orderBack: self]; // Make sure the full screen window is part of the correct Space.
    270271    [[self window] enterFullScreenMode:self];
    271272}
Note: See TracChangeset for help on using the changeset viewer.