Changeset 171257 in webkit

Timestamp:

Jul 18, 2014 6:30:35 PM (10 years ago)

Author:

oliver@apple.com

Message:

We don't provide an extension to the temp file used for uploads
​https://bugs.webkit.org/show_bug.cgi?id=135079

Reviewed by Sam Weinig.

Make sure didChooseFilesForOpenPanelWithDisplayStringAndIcon vends
extensions for the files passed to the content process.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didChooseFilesForOpenPanelWithDisplayStringAndIcon):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebPageProxy.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-07-18  Oliver Hunt  <oliver@apple.com>
+
+        We don't provide an extension to the temp file used for uploads
+        https://bugs.webkit.org/show_bug.cgi?id=135079
+
+        Reviewed by Sam Weinig.
+
+        Make sure didChooseFilesForOpenPanelWithDisplayStringAndIcon vends
+        extensions for the files passed to the content process.
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::didChooseFilesForOpenPanelWithDisplayStringAndIcon):
+
 2014-07-18  Tim Horton  <timothy_horton@apple.com>
 

trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp

@@ -3776 +3776 @@
         return;
 
+#if ENABLE(SANDBOX_EXTENSIONS)
+    // FIXME: The sandbox extensions should be sent with the DidChooseFilesForOpenPanel message. This
+    // is gated on a way of passing SandboxExtension::Handles in a Vector.
+    for (size_t i = 0; i < fileURLs.size(); ++i) {
+        SandboxExtension::Handle sandboxExtensionHandle;
+        SandboxExtension::createHandle(fileURLs[i], SandboxExtension::ReadOnly, sandboxExtensionHandle);
+        m_process->send(Messages::WebPage::ExtendSandboxForFileFromOpenPanel(sandboxExtensionHandle), m_pageID);
+    }
+#endif
+
     m_process->send(Messages::WebPage::DidChooseFilesForOpenPanelWithDisplayStringAndIcon(fileURLs, displayString, iconData ? iconData->dataReference() : IPC::DataReference()), m_pageID);