Changeset 171258 in webkit

Timestamp:

Jul 18, 2014 9:59:32 PM (10 years ago)

Author:

rniwa@webkit.org

Message:

Perf dashboard shouldn't show the full git hash
​https://bugs.webkit.org/show_bug.cgi?id=135083

Reviewed by Benjamin Poulain.

Detect Git/Mercurial hash by checking the length.

If it's a hash, use the first 8 characters in the label
while retaining the full length to be used in hyperlinks.

• public/js/helper-classes.js:

(.this.formattedRevisions):
(TestBuild):

Location:

trunk/Websites/perf.webkit.org

Files:

• ChangeLog (modified) (1 diff)
• public/js/helper-classes.js (modified) (2 diffs)

trunk/Websites/perf.webkit.org/ChangeLog

@@ +1 @@
+2014-07-18  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Perf dashboard shouldn't show the full git hash
+        https://bugs.webkit.org/show_bug.cgi?id=135083
+
+        Reviewed by Benjamin Poulain.
+
+        Detect Git/Mercurial hash by checking the length.
+
+        If it's a hash, use the first 8 characters in the label
+        while retaining the full length to be used in hyperlinks.
+
+        * public/js/helper-classes.js:
+        (.this.formattedRevisions):
+        (TestBuild):
+
 2014-05-29  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Websites/perf.webkit.org/public/js/helper-classes.js

@@ -86 +86 @@
 
             var revisionPrefix = '';
-            var revisionDelimitor = '-';
+            var revisionDelimiter = '-';
+            var isHash = false;
             if (parseInt(currentRevision) == currentRevision) { // e.g. r12345.
                 revisionPrefix = 'r';
@@ -92 +93 @@
                     previousRevision = (parseInt(previousRevision) + 1);
             } else if (currentRevision.indexOf(' ') >= 0) // e.g. 10.9 13C64.
-                revisionDelimitor = ' - ';
+                revisionDelimiter = ' - ';
+            else if (currentRevision.length == 40) // e.g. git hash
+                isHash = true;
 
             var labelForThisRepository;
-            if (previousRevision)
-                labelForThisRepository = revisionPrefix + previousRevision + revisionDelimitor + revisionPrefix + currentRevision;
-            else
-                labelForThisRepository = '@ ' + revisionPrefix + currentRevision;
+            if (isHash) {
+                formattedCurrentHash = currentRevision.substring(0, 8);
+                if (previousRevision)
+                    labelForThisRepository = previousRevision.substring(0, 8) + '..' + formattedCurrentHash;
+                else
+                    labelForThisRepository = '@ ' + formattedCurrentHash;
+            } else {
+                if (previousRevision)
+                    labelForThisRepository = revisionPrefix + previousRevision + revisionDelimiter + revisionPrefix + currentRevision;
+                else
+                    labelForThisRepository = '@ ' + revisionPrefix + currentRevision;
+            }
 
             var url;