Changeset 171277 in webkit

Timestamp:

Jul 20, 2014 8:08:06 AM (10 years ago)

Author:

ddkilzer@apple.com

Message:

Checker: Value stored to 'kernResult' is never read (LayoutTestHelper.m:164)
<​http://webkit.org/b/135096>

Reviewed by Alexey Proskuryakov.

• DumpRenderTree/mac/LayoutTestHelper.m:

(lockDownDiscreteGraphics): Check the return values of
IOServiceOpen() and IOObjectRelease(), and log if not
KERN_SUCCESS.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• DumpRenderTree/mac/LayoutTestHelper.m (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2014-07-20  David Kilzer  <ddkilzer@apple.com>
+
+        Checker: Value stored to 'kernResult' is never read (LayoutTestHelper.m:164)
+        <http://webkit.org/b/135096>
+
+        Reviewed by Alexey Proskuryakov.
+
+        * DumpRenderTree/mac/LayoutTestHelper.m:
+        (lockDownDiscreteGraphics): Check the return values of
+        IOServiceOpen() and IOObjectRelease(), and log if not
+        KERN_SUCCESS.
+
 2014-07-19  Anders Carlsson  <andersca@apple.com>
 

trunk/Tools/DumpRenderTree/mac/LayoutTestHelper.m

@@ -163 +163 @@
     // This call stalls until the graphics device lock is granted.
     kernResult = IOServiceOpen(serviceObject, mach_task_self(), 1, &permanentLockDownService);
-    IOObjectRelease(serviceObject);
+    if (kernResult != KERN_SUCCESS) {
+        NSLog(@"IOServiceOpen() failed in %s with kernResult = %d", __FUNCTION__, kernResult);
+        return;
+    }
+
+    kernResult = IOObjectRelease(serviceObject);
+    if (kernResult != KERN_SUCCESS)
+        NSLog(@"IOObjectRelease() failed in %s with kernResult = %d", __FUNCTION__, kernResult);
 }