Changeset 171278 in webkit

Timestamp:

Jul 20, 2014 9:16:57 AM (10 years ago)

Author:

commit-queue@webkit.org

Message:

ES6: Implement Math.sign()
​https://bugs.webkit.org/show_bug.cgi?id=134980

Patch by Diego Pino Garcia <Diego Pino Garcia> on 2014-07-20
Reviewed by Darin Adler.

Source/JavaScriptCore:

• runtime/MathObject.cpp:

(JSC::MathObject::finishCreation):
(JSC::mathProtoFuncSign):

LayoutTests:

• js/script-tests/Object-getOwnPropertyNames.js:
• js/script-tests/math.js:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/js/Object-getOwnPropertyNames-expected.txt (modified) (1 diff)
• LayoutTests/js/math-expected.txt (modified) (1 diff)
• LayoutTests/js/script-tests/Object-getOwnPropertyNames.js (modified) (1 diff)
• LayoutTests/js/script-tests/math.js (modified) (1 diff)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/runtime/MathObject.cpp (modified) (3 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-07-20  Diego Pino Garcia  <dpino@igalia.com>
+
+        ES6: Implement Math.sign()
+        https://bugs.webkit.org/show_bug.cgi?id=134980
+
+        Reviewed by Darin Adler.
+
+        * js/script-tests/Object-getOwnPropertyNames.js:
+        * js/script-tests/math.js:
+
 2014-07-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
 

trunk/LayoutTests/js/Object-getOwnPropertyNames-expected.txt

@@ -59 +59 @@
 PASS getSortedOwnPropertyNames(Error) is ['length', 'name', 'prototype']
 PASS getSortedOwnPropertyNames(Error.prototype) is ['constructor', 'message', 'name', 'toString']
-PASS getSortedOwnPropertyNames(Math) is ['E','LN10','LN2','LOG10E','LOG2E','PI','SQRT1_2','SQRT2','abs','acos','acosh','asin','asinh','atan','atan2','atanh','cbrt','ceil','cos','cosh','exp','expm1','floor','fround','hypot','imul','log','log10','log1p','log2','max','min','pow','random','round','sin','sinh','sqrt','tan','tanh','trunc']
+PASS getSortedOwnPropertyNames(Math) is ['E','LN10','LN2','LOG10E','LOG2E','PI','SQRT1_2','SQRT2','abs','acos','acosh','asin','asinh','atan','atan2','atanh','cbrt','ceil','cos','cosh','exp','expm1','floor','fround','hypot','imul','log','log10','log1p','log2','max','min','pow','random','round','sign','sin','sinh','sqrt','tan','tanh','trunc']
 PASS getSortedOwnPropertyNames(JSON) is ['parse', 'stringify']
 PASS globalPropertyNames.indexOf('NaN') != -1 is true

trunk/LayoutTests/js/math-expected.txt

@@ -182 +182 @@
 PASS Math.round(Infinity) is Infinity
 PASS Math.round(-Infinity) is -Infinity
+PASS Math.sign(NaN) is NaN
+PASS Math.sign('string') is NaN
+PASS Math.sign([1, 2, 3]) is NaN
+PASS Math.sign({}) is NaN
+PASS Math.sign(0) is 0
+PASS Math.sign(-0) is -0
+PASS Math.sign(-1) is -1
+PASS Math.sign(1) is 1
+PASS Math.sign(0.1) is 1
+PASS Math.sign(-0.1) is -1
+PASS Math.sign(10000) is 1
+PASS Math.sign(-10000) is -1
+PASS Math.sign(Number.MIN_VALUE) is 1
+PASS Math.sign(-Number.MIN_VALUE) is -1
+PASS Math.sign(Number.MAX_VALUE) is 1
+PASS Math.sign(-Number.MAX_VALUE) is -1
+PASS Math.sign(Infinity) is 1
+PASS Math.sign(-Infinity) is -1
 PASS Math.sin(NaN) is NaN
 PASS Math.sin(0) is 0

trunk/LayoutTests/js/script-tests/Object-getOwnPropertyNames.js

@@ -67 +67 @@
     "Error": "['length', 'name', 'prototype']",
     "Error.prototype": "['constructor', 'message', 'name', 'toString']",
-    "Math": "['E','LN10','LN2','LOG10E','LOG2E','PI','SQRT1_2','SQRT2','abs','acos','acosh','asin','asinh','atan','atan2','atanh','cbrt','ceil','cos','cosh','exp','expm1','floor','fround','hypot','imul','log','log10','log1p','log2','max','min','pow','random','round','sin','sinh','sqrt','tan','tanh','trunc']",
+    "Math": "['E','LN10','LN2','LOG10E','LOG2E','PI','SQRT1_2','SQRT2','abs','acos','acosh','asin','asinh','atan','atan2','atanh','cbrt','ceil','cos','cosh','exp','expm1','floor','fround','hypot','imul','log','log10','log1p','log2','max','min','pow','random','round','sign','sin','sinh','sqrt','tan','tanh','trunc']",
     "JSON": "['parse', 'stringify']"
 };

trunk/LayoutTests/js/script-tests/math.js

@@ -255 +255 @@
 shouldBe("Math.round(-Infinity)", "-Infinity");
 
+shouldBe("Math.sign(NaN)", "NaN");
+shouldBe("Math.sign('string')", "NaN");
+shouldBe("Math.sign([1, 2, 3])", "NaN");
+shouldBe("Math.sign({})", "NaN");
+shouldBe("Math.sign(0)", "0");
+shouldBe("Math.sign(-0)", "-0");
+shouldBe("Math.sign(-1)", "-1");
+shouldBe("Math.sign(1)", "1");
+shouldBe("Math.sign(0.1)", "1");
+shouldBe("Math.sign(-0.1)", "-1");
+shouldBe("Math.sign(10000)", "1");
+shouldBe("Math.sign(-10000)", "-1");
+shouldBe("Math.sign(Number.MIN_VALUE)", "1");
+shouldBe("Math.sign(-Number.MIN_VALUE)", "-1");
+shouldBe("Math.sign(Number.MAX_VALUE)", "1");
+shouldBe("Math.sign(-Number.MAX_VALUE)", "-1");
+shouldBe("Math.sign(Infinity)", "1");
+shouldBe("Math.sign(-Infinity)", "-1");
+
 shouldBe("Math.sin(NaN)", "NaN");
 shouldBe("Math.sin(0)", "0");

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2014-07-20  Diego Pino Garcia  <dpino@igalia.com>
+
+        ES6: Implement Math.sign()
+        https://bugs.webkit.org/show_bug.cgi?id=134980
+
+        Reviewed by Darin Adler.
+
+        * runtime/MathObject.cpp:
+        (JSC::MathObject::finishCreation):
+        (JSC::mathProtoFuncSign):
+
 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
 

trunk/Source/JavaScriptCore/runtime/MathObject.cpp

@@ -62 +62 @@
 static EncodedJSValue JSC_HOST_CALL mathProtoFuncRandom(ExecState*);
 static EncodedJSValue JSC_HOST_CALL mathProtoFuncRound(ExecState*);
+static EncodedJSValue JSC_HOST_CALL mathProtoFuncSign(ExecState*);
 static EncodedJSValue JSC_HOST_CALL mathProtoFuncSin(ExecState*);
 static EncodedJSValue JSC_HOST_CALL mathProtoFuncSinh(ExecState*);
@@ -121 +122 @@
     putDirectNativeFunctionWithoutTransition(vm, globalObject, Identifier(&vm, "random"), 0, mathProtoFuncRandom, NoIntrinsic, DontEnum | Function);
     putDirectNativeFunctionWithoutTransition(vm, globalObject, Identifier(&vm, "round"), 1, mathProtoFuncRound, RoundIntrinsic, DontEnum | Function);
+    putDirectNativeFunctionWithoutTransition(vm, globalObject, Identifier(&vm, "sign"), 1, mathProtoFuncSign, NoIntrinsic, DontEnum | Function);
     putDirectNativeFunctionWithoutTransition(vm, globalObject, Identifier(&vm, "sin"), 1, mathProtoFuncSin, SinIntrinsic, DontEnum | Function);
     putDirectNativeFunctionWithoutTransition(vm, globalObject, Identifier(&vm, "sinh"), 1, mathProtoFuncSinh, NoIntrinsic, DontEnum | Function);
@@ -302 +304 @@
     double integer = ceil(arg);
     return JSValue::encode(jsNumber(integer - (integer - arg > 0.5)));
+}
+
+EncodedJSValue JSC_HOST_CALL mathProtoFuncSign(ExecState* exec)
+{
+    double arg = exec->argument(0).toNumber(exec);
+    if (std::isnan(arg))
+        return JSValue::encode(jsNaN());
+    if (!arg)
+        return JSValue::encode(std::signbit(arg) ? jsNumber(-0.0) : jsNumber(0));
+    return JSValue::encode(jsNumber(std::signbit(arg) ? -1 : 1));
 }