Changeset 171725 in webkit

Timestamp:

Jul 29, 2014 1:12:46 AM (10 years ago)

Author:

zandobersek@gmail.com

Message:

[TexMap] GraphicsLayerTextureMapper::addAnimation() box size parameter should be FloatSize
​https://bugs.webkit.org/show_bug.cgi?id=135237

Reviewed by Martin Robinson.

• platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::addAnimation):

• platform/graphics/texmap/GraphicsLayerTextureMapper.h: The boxSize parameter of the

addAnimation() method must be of the same type as the parameter in the base class
declaration -- a const FloatSize reference. Only then is the base virtual method
actually overriden.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/texmap/GraphicsLayerTextureMapper.cpp (modified) (1 diff)
• platform/graphics/texmap/GraphicsLayerTextureMapper.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-07-29  Zan Dobersek  <zdobersek@igalia.com>
+
+        [TexMap] GraphicsLayerTextureMapper::addAnimation() box size parameter should be FloatSize
+        https://bugs.webkit.org/show_bug.cgi?id=135237
+
+        Reviewed by Martin Robinson.
+
+        * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
+        (WebCore::GraphicsLayerTextureMapper::addAnimation):
+        * platform/graphics/texmap/GraphicsLayerTextureMapper.h: The boxSize parameter of the
+        addAnimation() method must be of the same type as the parameter in the base class
+        declaration -- a const FloatSize reference. Only then is the base virtual method
+        actually overriden.
+
 2014-07-28  Dan Bernstein  <mitz@apple.com>
 

trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp

@@ -621 +621 @@
 }
 
-bool GraphicsLayerTextureMapper::addAnimation(const KeyframeValueList& valueList, const IntSize& boxSize, const Animation* anim, const String& keyframesName, double timeOffset)
+bool GraphicsLayerTextureMapper::addAnimation(const KeyframeValueList& valueList, const FloatSize& boxSize, const Animation* anim, const String& keyframesName, double timeOffset)
 {
     ASSERT(!keyframesName.isEmpty());

trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.h

@@ -82 +82 @@
     inline int changeMask() const { return m_changeMask; }
 
-    virtual bool addAnimation(const KeyframeValueList&, const IntSize&, const Animation*, const String&, double);
+    virtual bool addAnimation(const KeyframeValueList&, const FloatSize&, const Animation*, const String&, double);
     virtual void pauseAnimation(const String&, double);
     virtual void removeAnimation(const String&);