Changeset 172116 in webkit


Ignore:
Timestamp:
Aug 5, 2014 6:30:27 PM (10 years ago)
Author:
Bem Jones-Bey
Message:

[GTK] [CSS Shapes] Layout test fast/shapes/shape-outside-floats/shape-outside-image-shape-margin.html fails
​https://bugs.webkit.org/show_bug.cgi?id=135585

Reviewed by Zoltan Horvath.

The positioning was dependent on the font metrics of the <p> tag,
which differs between platforms. This fixes that, which should make
the test pass on all platforms.

  • fast/shapes/shape-outside-floats/shape-outside-image-shape-margin-expected.html:
  • fast/shapes/shape-outside-floats/shape-outside-image-shape-margin.html:
  • platform/gtk/TestExpectations:
Location:
trunk/LayoutTests
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r172112 r172116  
     12014-08-05  Bem Jones-Bey  <bjonesbe@adobe.com>
     2
     3        [GTK] [CSS Shapes] Layout test fast/shapes/shape-outside-floats/shape-outside-image-shape-margin.html fails
     4        https://bugs.webkit.org/show_bug.cgi?id=135585
     5
     6        Reviewed by Zoltan Horvath.
     7
     8        The positioning was dependent on the font metrics of the <p> tag,
     9        which differs between platforms. This fixes that, which should make
     10        the test pass on all platforms.
     11
     12        * fast/shapes/shape-outside-floats/shape-outside-image-shape-margin-expected.html:
     13        * fast/shapes/shape-outside-floats/shape-outside-image-shape-margin.html:
     14        * platform/gtk/TestExpectations:
     15
    1162014-08-05  Simon Fraser  <simon.fraser@apple.com>
    217

  • trunk/LayoutTests/fast/shapes/shape-outside-floats/shape-outside-image-shape-margin-expected.html

    r172010 r172116  
    55    <link rel="author" title="Rebecca Hauck" href="rhauck@adobe.com"/>
    66    <style type="text/css">
     7        #outer {
     8            position: relative;
     9            width: 100px;
     10            height: 250px;
     11        }
    712        #container {
    813            position: absolute;
    9             top: 170px;
     14            top: 120px;
    1015        }
    1116        #shape-ref-div {
    … …  
    2530        The test passes if the green rectangle is below the line. There should be no red.
    2631    </p>
    27     <div id="container">
    28         <div id="line"><div>
    29         <div id="shape-ref-div"></div>
     32    <div id="outer">
     33        <div id="container">
     34            <div id="line"><div>
     35            <div id="shape-ref-div"></div>
     36        </div>
    3037    </div>
    3138</body>

  • trunk/LayoutTests/fast/shapes/shape-outside-floats/shape-outside-image-shape-margin.html

    r172010 r172116  
    1313                                 text to be pushed below the defined shape."/>
    1414    <style type="text/css">
     15        #outer {
     16            position: relative;
     17            width: 100px;
     18            height: 250px;
     19        }
    1520        .container {
    1621              position: relative;
    … …  
    3439        #ref {
    3540            position: absolute;
    36             top: 170px;
     41            top: 120px;
    3742        }
    3843        #line {
    … …  
    5358        The test passes if the green rectangle is below the line. There should be no red.
    5459    </p>
    55     <div id="ref">
    56         <div id="line"></div>
    57         <div id="failure"></div>
     60    <div id="outer">
     61        <div id="ref">
     62            <div id="line"></div>
     63            <div id="failure"></div>
     64        </div>
     65        <div id="test" class="container">
     66            <div id="shape-div"></div>
     67            x x
     68        </div>
    5869    </div>
    59     <div id="test" class="container">
    60         <div id="shape-div"></div>
    61         x x
    62     </div>
    63 
    6470</body>
    6571</html>

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r172017 r172116  
    431431
    432432webkit.org/b/133806 svg/masking/mask-transformed-text-missing.svg [ ImageOnlyFailure ]
    433 
    434 webkit.org/b/135585 fast/shapes/shape-outside-floats/shape-outside-image-shape-margin.html [ ImageOnlyFailure ]
    435433
    436434#////////////////////////////////////////////////////////////////////////////////////////
Note: See TracChangeset for help on using the changeset viewer.