Changeset 172437 in webkit

Timestamp:

Aug 12, 2014 1:22:05 AM (10 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL][WK2] Minibrowser: Enhance the application to use download directory selector.
​https://bugs.webkit.org/show_bug.cgi?id=135791

Patch by Shivakumar JM <​shiva.jm@samsung.com> on 2014-08-12
Reviewed by Gyuyoung Kim.

Currently Minibrowser stores the downloaded files to /tmp directory, add support so that destination folder can be selected by the
user.

• MiniBrowser/efl/main.c:

(on_download_request):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• MiniBrowser/efl/main.c (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2014-08-12  Shivakumar JM  <shiva.jm@samsung.com>
+
+        [EFL][WK2] Minibrowser: Enhance the application to use download directory selector.
+        https://bugs.webkit.org/show_bug.cgi?id=135791
+
+        Reviewed by Gyuyoung Kim.
+
+        Currently Minibrowser stores the downloaded files to /tmp directory, add support so that destination folder can be selected by the
+        user.
+
+        * MiniBrowser/efl/main.c:
+        (on_download_request):
+
 2014-08-11  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
 

trunk/Tools/MiniBrowser/efl/main.c

@@ -655 +655 @@
 {
     Ewk_Download_Job *download = (Ewk_Download_Job *)event_info;
-
-    // FIXME: The destination folder should be selected by the user but we set it to '/tmp' for now.
+    Browser_Window *window = (Browser_Window *)user_data;
+
     Eina_Strbuf *destination_path = eina_strbuf_new();
+
+    const char *home_path = getenv("HOME");
+    Eina_Stringshare *save_file_path = show_file_entry_dialog(window, "DOWNLOAD", home_path ? home_path : "/tmp");
+
+    if (save_file_path)
+        eina_strbuf_append_printf(destination_path, "%s", save_file_path);
+    else
+        eina_strbuf_append(destination_path, "/tmp");
 
     const char *suggested_name = ewk_download_job_suggested_filename_get(download);
     if (suggested_name && *suggested_name)
-        eina_strbuf_append_printf(destination_path, "/tmp/%s", suggested_name);
+        eina_strbuf_append_printf(destination_path, "/%s", suggested_name);
     else {
         // Generate a unique file name since no name was suggested.
-        char unique_path[] = "/tmp/downloaded-file.XXXXXX";
-        if (mkstemp(unique_path) == -1) {
+        eina_strbuf_append(destination_path, "/downloaded-file.XXXXXX");
+        char *url = NULL;
+        url = eina_strbuf_string_steal(destination_path);
+        if (mkstemp(url) == -1) {
             info("ERROR: Could not generate a unique file name.");
             return;
         }
-        eina_strbuf_append(destination_path, unique_path);
+        eina_strbuf_append(destination_path, url);
     }
 
@@ -675 +685 @@
     info("Downloading: %s", eina_strbuf_string_get(destination_path));
     eina_strbuf_free(destination_path);
+    eina_stringshare_del(save_file_path);
 }