Changeset 172638 in webkit

Timestamp:

Aug 15, 2014 12:03:59 PM (10 years ago)

Author:

commit-queue@webkit.org

Message:

run-webkit-tests should skip 'support' directories
​https://bugs.webkit.org/show_bug.cgi?id=135910

Patch by Rebecca Hauck <​rhauck@adobe.com> on 2014-08-15
Reviewed by Bem Jones-Bey.

This patch adds the 'support' directory to the list
of dirs to skip when looking for runnable tests.
the W3C uses this name for support files, so tests
imported from the W3C will not work without this change
or without many edits.

• Scripts/webkitpy/port/base.py:

(Port._real_tests):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/port/base.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2014-08-15  Rebecca Hauck  <rhauck@adobe.com>
+
+        run-webkit-tests should skip 'support' directories
+        https://bugs.webkit.org/show_bug.cgi?id=135910
+
+        Reviewed by Bem Jones-Bey.
+        
+        This patch adds the 'support' directory to the list
+        of dirs to skip when looking for runnable tests.
+        the W3C uses this name for support files, so tests
+        imported from the W3C will not work without this change
+        or without many edits.
+
+        * Scripts/webkitpy/port/base.py:
+        (Port._real_tests):
+
 2014-08-14  Brent Fulgham  <bfulgham@apple.com>
 

trunk/Tools/Scripts/webkitpy/port/base.py

@@ -544 +544 @@
     def _real_tests(self, paths):
         # When collecting test cases, skip these directories
-        skipped_directories = set(['.svn', '_svn', 'resources', 'script-tests', 'reference', 'reftest'])
+        skipped_directories = set(['.svn', '_svn', 'resources', 'support', 'script-tests', 'reference', 'reftest'])
         files = find_files.find(self._filesystem, self.layout_tests_dir(), paths, skipped_directories, Port._is_test_file, self.test_key)
         return [self.relative_test_filename(f) for f in files]