Changeset 172647 in webkit

Timestamp:

Aug 15, 2014 1:48:35 PM (10 years ago)

Author:

krit@webkit.org

Message:

Turn r/rx/ry to presentation attributes
​https://bugs.webkit.org/show_bug.cgi?id=135978

Source/WebCore:

Unreviewed typo.

Patch by Dirk Schulze <​krit@webkit.org> on 2014-08-15

• rendering/svg/RenderSVGEllipse.cpp:

(WebCore::RenderSVGEllipse::calculateRadiiAndCenter):

LayoutTests:

Patch by Dirk Schulze <​krit@webkit.org> on 2014-08-15
Reviewed by Dean Jackson.

Rebaseline test.

• svg/css/parse-length-expected.txt:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/svg/css/parse-length-expected.txt (modified) (4 diffs)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/svg/RenderSVGEllipse.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-08-15  Dirk Schulze  <krit@webkit.org>
+
+        Turn r/rx/ry to presentation attributes
+        https://bugs.webkit.org/show_bug.cgi?id=135978
+
+        Reviewed by Dean Jackson.
+
+        Rebaseline test.
+
+        * svg/css/parse-length-expected.txt:
+
 2014-08-15  Dirk Schulze  <krit@webkit.org>
 

trunk/LayoutTests/svg/css/parse-length-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: Error: Invalid value for <rect> attribute rx="  100"
+CONSOLE MESSAGE: Error: Invalid value for <rect> attribute rx="100   "
+CONSOLE MESSAGE: Error: Invalid negative value for <rect> attribute rx="-200px"
+CONSOLE MESSAGE: Error: Invalid value for <rect> attribute ry="  100"
+CONSOLE MESSAGE: Error: Invalid value for <rect> attribute ry="100   "
+CONSOLE MESSAGE: Error: Invalid negative value for <rect> attribute ry="-200px"
 CONSOLE MESSAGE: Error: Invalid value for <rect> attribute width="auto"
 CONSOLE MESSAGE: Error: Invalid value for <rect> attribute width="  100"
@@ -6 +12 @@
 CONSOLE MESSAGE: Error: Invalid value for <rect> attribute y="  100"
 CONSOLE MESSAGE: Error: Invalid value for <rect> attribute y="100   "
+CONSOLE MESSAGE: Error: Invalid value for <rect> attribute rx="auto"
+CONSOLE MESSAGE: Error: Invalid value for <rect> attribute rx="100   px"
+CONSOLE MESSAGE: Error: Invalid value for <rect> attribute rx="100px;"
+CONSOLE MESSAGE: Error: Invalid value for <rect> attribute rx="100px !important"
+CONSOLE MESSAGE: Error: Invalid value for <rect> attribute rx="{ 100px }"
+CONSOLE MESSAGE: Error: Invalid value for <rect> attribute ry="auto"
+CONSOLE MESSAGE: Error: Invalid value for <rect> attribute ry="100   px"
+CONSOLE MESSAGE: Error: Invalid value for <rect> attribute ry="100px;"
+CONSOLE MESSAGE: Error: Invalid value for <rect> attribute ry="100px !important"
+CONSOLE MESSAGE: Error: Invalid value for <rect> attribute ry="{ 100px }"
 CONSOLE MESSAGE: Error: Invalid value for <rect> attribute width="100   px"
 CONSOLE MESSAGE: Error: Invalid value for <rect> attribute width="100px;"
@@ -40 +56 @@
 PASS computedStyle("cy", "20%") is "20%"
 PASS computedStyle("cy", "-200px") is "-200px"
+PASS computedStyle("r", "  100") is "100px"
+PASS computedStyle("r", "100   ") is "100px"
+PASS computedStyle("r", "100px") is "100px"
+PASS computedStyle("r", "1em") is "16px"
+PASS computedStyle("r", "1ex") is "12.800000190734863px"
+PASS computedStyle("r", "20%") is "20%"
+PASS computedStyle("r", "-200px") is "-200px"
+PASS computedStyle("rx", "  100") is "100px"
+PASS computedStyle("rx", "100   ") is "100px"
+PASS computedStyle("rx", "100px") is "100px"
+PASS computedStyle("rx", "1em") is "16px"
+PASS computedStyle("rx", "1ex") is "12.800000190734863px"
+PASS computedStyle("rx", "20%") is "20%"
+PASS computedStyle("rx", "-200px") is "-200px"
+PASS computedStyle("ry", "  100") is "100px"
+PASS computedStyle("ry", "100   ") is "100px"
+PASS computedStyle("ry", "100px") is "100px"
+PASS computedStyle("ry", "1em") is "16px"
+PASS computedStyle("ry", "1ex") is "12.800000190734863px"
+PASS computedStyle("ry", "20%") is "20%"
+PASS computedStyle("ry", "-200px") is "-200px"
 PASS computedStyle("width", "auto") is "auto"
 PASS computedStyle("width", "  100") is "100px"
@@ -71 +108 @@
 PASS computedStyle("cy", "100px !important") is "0px"
 PASS computedStyle("cy", "{ 100px }") is "0px"
+PASS computedStyle("r", "auto") is "0px"
+PASS computedStyle("r", "100   px") is "0px"
+PASS computedStyle("r", "100px;") is "0px"
+PASS computedStyle("r", "100px !important") is "0px"
+PASS computedStyle("r", "{ 100px }") is "0px"
+PASS computedStyle("rx", "auto") is "0px"
+PASS computedStyle("rx", "100   px") is "0px"
+PASS computedStyle("rx", "100px;") is "0px"
+PASS computedStyle("rx", "100px !important") is "0px"
+PASS computedStyle("rx", "{ 100px }") is "0px"
+PASS computedStyle("ry", "auto") is "0px"
+PASS computedStyle("ry", "100   px") is "0px"
+PASS computedStyle("ry", "100px;") is "0px"
+PASS computedStyle("ry", "100px !important") is "0px"
+PASS computedStyle("ry", "{ 100px }") is "0px"
 PASS computedStyle("width", "100   px") is "auto"
 PASS computedStyle("width", "100px;") is "auto"

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-08-15  Dirk Schulze  <krit@webkit.org>
+
+        Turn r/rx/ry to presentation attributes
+        https://bugs.webkit.org/show_bug.cgi?id=135978
+
+        Unreviewed typo.
+
+        * rendering/svg/RenderSVGEllipse.cpp:
+        (WebCore::RenderSVGEllipse::calculateRadiiAndCenter):
+
 2014-08-15  Dirk Schulze  <krit@webkit.org>
 

trunk/Source/WebCore/rendering/svg/RenderSVGEllipse.cpp

@@ -89 +89 @@
 
     ASSERT(isSVGEllipseElement(graphicsElement()));
-    m_radii = FloatSize(lengthContext.valueForLength(style().svgStyle().rx()), lengthContext.valueForLength(style().svgStyle().ry()));
+    m_radii = FloatSize(
+        lengthContext.valueForLength(style().svgStyle().rx(), LengthModeWidth),
+        lengthContext.valueForLength(style().svgStyle().ry(), LengthModeHeight));
 }