Changeset 172690 in webkit

Timestamp:

Aug 16, 2014 7:26:17 AM (10 years ago)

Author:

commit-queue@webkit.org

Message:

[GTK] build fails with error: cannot allocate an object of abstract type 'WebKit::PageClientImpl'
​https://bugs.webkit.org/show_bug.cgi?id=136017

Patch by Byungseon Shin <​sun.shin@lge.com> on 2014-08-16
Reviewed by Gyuyoung Kim.

• UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::didFirstVisuallyNonEmptyLayoutForMainFrame):
(WebKit::PageClientImpl::didFinishLoadForMainFrame):

• UIProcess/API/gtk/PageClientImpl.h:

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/gtk/PageClientImpl.cpp (modified) (1 diff)
• UIProcess/API/gtk/PageClientImpl.h (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2014-08-16  Byungseon Shin  <sun.shin@lge.com>
+
+        [GTK] build fails with error: cannot allocate an object of abstract type 'WebKit::PageClientImpl'
+        https://bugs.webkit.org/show_bug.cgi?id=136017 
+
+        Reviewed by Gyuyoung Kim.
+
+        * UIProcess/API/gtk/PageClientImpl.cpp:
+        (WebKit::PageClientImpl::didFirstVisuallyNonEmptyLayoutForMainFrame):
+        (WebKit::PageClientImpl::didFinishLoadForMainFrame):
+        * UIProcess/API/gtk/PageClientImpl.h:
+
 2014-08-15  Ryuan Choi  <ryuan.choi@samsung.com>
 

trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp

@@ -399 +399 @@
 }
 
+void PageClientImpl::didFirstVisuallyNonEmptyLayoutForMainFrame()
+{
+}
+
+void PageClientImpl::didFinishLoadForMainFrame()
+{
+}
+
 } // namespace WebKit

trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h

@@ -128 +128 @@
     virtual void willRecordNavigationSnapshot(WebBackForwardListItem&) override;
 
+    virtual void didFirstVisuallyNonEmptyLayoutForMainFrame() override;
+    virtual void didFinishLoadForMainFrame() override;
+
     virtual void doneWithTouchEvent(const NativeWebTouchEvent&, bool wasEventHandled) override;