Changeset 172799 in webkit


Ignore:
Timestamp:
Aug 20, 2014 10:59:10 AM (10 years ago)
Author:
commit-queue@webkit.org
Message:

Enable ARM64 disassembler on EFL
https://bugs.webkit.org/show_bug.cgi?id=136089

Patch by Akos Kiss <akiss@inf.u-szeged.hu> on 2014-08-20
Reviewed by Filip Pizlo.

Source/JavaScriptCore:

  • CMakeLists.txt:

Added disassembler/ARM64Disassembler.cpp and
disassembler/ARM64/A64DOpcode.cpp to JavaScriptCore_SOURCES.

  • disassembler/ARM64/A64DOpcode.cpp:

Added USE(ARM64_DISASSEMBLER) guard around implementation.

  • disassembler/ARM64/A64DOpcode.h:

(JSC::ARM64Disassembler::A64DOpcode::appendUnsignedImmediate64):
(JSC::ARM64Disassembler::A64DOpcode::appendPCRelativeOffset):
Made format strings portable by changing "%llx" to "%" PRIx64 for
uint64_t arguments.

Source/WTF:

  • wtf/Platform.h:

Enable WTF_USE_ARM64_DISASSEMBLER for EFL as well.

Location:
trunk/Source
Files:
6 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/CMakeLists.txt

    r172754 r172799  
    226226    dfg/DFGWorklist.cpp
    227227
     228    disassembler/ARM64/A64DOpcode.cpp
    228229    disassembler/ARMv7/ARMv7DOpcode.cpp
     230    disassembler/ARM64Disassembler.cpp
    229231    disassembler/ARMv7Disassembler.cpp
    230232    disassembler/Disassembler.cpp
  • trunk/Source/JavaScriptCore/ChangeLog

    r172794 r172799  
     12014-08-20  Akos Kiss  <akiss@inf.u-szeged.hu>
     2
     3        Enable ARM64 disassembler on EFL
     4        https://bugs.webkit.org/show_bug.cgi?id=136089
     5
     6        Reviewed by Filip Pizlo.
     7
     8        * CMakeLists.txt:
     9        Added disassembler/ARM64Disassembler.cpp and
     10        disassembler/ARM64/A64DOpcode.cpp to JavaScriptCore_SOURCES.
     11
     12        * disassembler/ARM64/A64DOpcode.cpp:
     13        Added USE(ARM64_DISASSEMBLER) guard around implementation.
     14
     15        * disassembler/ARM64/A64DOpcode.h:
     16        (JSC::ARM64Disassembler::A64DOpcode::appendUnsignedImmediate64):
     17        (JSC::ARM64Disassembler::A64DOpcode::appendPCRelativeOffset):
     18        Made format strings portable by changing "%llx" to "%" PRIx64 for
     19        uint64_t arguments.
     20
    1212014-08-19  Filip Pizlo  <fpizlo@apple.com>
    222
  • trunk/Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.cpp

    r163027 r172799  
    2525
    2626#include "config.h"
     27
     28#if USE(ARM64_DISASSEMBLER)
     29
    2730#include "A64DOpcode.h"
    2831
     
    11951198
    11961199} } // namespace JSC::ARM64Disassembler
     1200
     1201#endif // USE(ARM64_DISASSEMBLER)
  • trunk/Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.h

    r163027 r172799  
    173173    void appendUnsignedImmediate64(uint64_t immediate)
    174174    {
    175         bufferPrintf("#0x%llx", immediate);
     175        bufferPrintf("#0x%" PRIx64, immediate);
    176176    }
    177177
    178178    void appendPCRelativeOffset(uint32_t* pc, int32_t immediate)
    179179    {
    180         bufferPrintf("0x%llx", reinterpret_cast<uint64_t>(pc + immediate));
     180        bufferPrintf("0x%" PRIx64, reinterpret_cast<uint64_t>(pc + immediate));
    181181    }
    182182
  • trunk/Source/WTF/ChangeLog

    r172790 r172799  
     12014-08-20  Akos Kiss  <akiss@inf.u-szeged.hu>
     2
     3        Enable ARM64 disassembler on EFL
     4        https://bugs.webkit.org/show_bug.cgi?id=136089
     5
     6        Reviewed by Filip Pizlo.
     7
     8        * wtf/Platform.h:
     9        Enable WTF_USE_ARM64_DISASSEMBLER for EFL as well.
     10
    1112014-08-19  Pratik Solanki  <psolanki@apple.com>
    212
  • trunk/Source/WTF/wtf/Platform.h

    r172790 r172799  
    677677#endif
    678678
    679 #if !defined(WTF_USE_ARM64_DISASSEMBLER) && ENABLE(JIT) && PLATFORM(IOS) && CPU(ARM64) && !USE(LLVM_DISASSEMBLER)
     679#if !defined(WTF_USE_ARM64_DISASSEMBLER) && ENABLE(JIT) && (PLATFORM(IOS) || PLATFORM(EFL)) && CPU(ARM64) && !USE(LLVM_DISASSEMBLER)
    680680#define WTF_USE_ARM64_DISASSEMBLER 1
    681681#endif
Note: See TracChangeset for help on using the changeset viewer.