Changeset 172838 in webkit

Timestamp:

Aug 21, 2014 4:11:12 PM (10 years ago)

Author:

mark.lam@apple.com

Message:

REGRESSION(r172808): It made 6 different tests fail on 32 bit platforms.
<​https://webkit.org/b/136123>

Reviewed by Filip Pizlo.

The original patch in r172808 removed the code to skip the top scope in
the 64-bit port of JIT::emitResolveClosure() but not in the 32-bit port.
This patch fixes that and achieves parity.

• jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emitResolveClosure):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• jit/JITPropertyAccess32_64.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2014-08-21  Mark Lam  <mark.lam@apple.com>
+
+        REGRESSION(r172808): It made 6 different tests fail on 32 bit platforms.
+        <https://webkit.org/b/136123>
+
+        Reviewed by Filip Pizlo.
+
+        The original patch in r172808 removed the code to skip the top scope in
+        the 64-bit port of JIT::emitResolveClosure() but not in the 32-bit port.
+        This patch fixes that and achieves parity.
+
+        * jit/JITPropertyAccess32_64.cpp:
+        (JSC::JIT::emitResolveClosure):
+
 2014-08-21  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/JavaScriptCore/jit/JITPropertyAccess32_64.cpp

@@ -618 +618 @@
     move(TrustedImm32(JSValue::CellTag), regT1);
     emitLoadPayload(JSStack::ScopeChain, regT0);
-    if (m_codeBlock->needsActivation()) {
-        emitLoadPayload(m_codeBlock->activationRegister().offset(), regT2);
-        loadPtr(Address(regT2, JSScope::offsetOfNext()), regT0);
-    }
     for (unsigned i = 0; i < depth; ++i)
         loadPtr(Address(regT0, JSScope::offsetOfNext()), regT0);