Changeset 172882 in webkit

Timestamp:

Aug 22, 2014 11:29:38 PM (10 years ago)

Author:

commit-queue@webkit.org

Message:

.:
[EFL] Turn on ENABLE_GAMEPAD_DEPRECATED option.
​https://bugs.webkit.org/show_bug.cgi?id=136110

Patch by KwangHyuk Kim <​hyuki.kim@samsung.com> on 2014-08-22
Reviewed by Gyuyoung Kim.

Turn on ENABLE_GAMEPAD_DEPRECATED option for the WK2 Efl.

• Source/cmake/OptionsEfl.cmake:

Source/WebCore:
[EFL] Fix build break caused by ENABLE_GAMEPAD_DEPRECATED.
​https://bugs.webkit.org/show_bug.cgi?id=136110

Patch by KwangHyuk Kim <​hyuki.kim@samsung.com> on 2014-08-22
Reviewed by Gyuyoung Kim.

WebCore_INCLUDE_DIRECTORY for gamepad was removed from WK2 Efl in order to fix build break when ENABLE_GAMEPAD_DEPRECATED is on.

No new tests because no functional changes.

• PlatformEfl.cmake:

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/PlatformEfl.cmake (modified) (1 diff)
• Source/cmake/OptionsEfl.cmake (modified) (1 diff)

trunk/ChangeLog

@@ +1 @@
+2014-08-22  KwangHyuk Kim  <hyuki.kim@samsung.com>
+
+        [EFL] Turn on ENABLE_GAMEPAD_DEPRECATED option.
+        https://bugs.webkit.org/show_bug.cgi?id=136110
+
+        Reviewed by Gyuyoung Kim.
+
+        Turn on ENABLE_GAMEPAD_DEPRECATED option for the WK2 Efl.
+
+        * Source/cmake/OptionsEfl.cmake:
+
 2014-08-22  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-08-22  KwangHyuk Kim  <hyuki.kim@samsung.com>
+
+        [EFL] Fix build break caused by ENABLE_GAMEPAD_DEPRECATED.
+        https://bugs.webkit.org/show_bug.cgi?id=136110
+
+        Reviewed by Gyuyoung Kim.
+
+        WebCore_INCLUDE_DIRECTORY for gamepad was removed from WK2 Efl in order to fix build break when ENABLE_GAMEPAD_DEPRECATED is on.
+
+        No new tests because no functional changes.
+
+        * PlatformEfl.cmake:
+
 2014-08-22  Benjamin Poulain  <benjamin@webkit.org>
 

trunk/Source/WebCore/PlatformEfl.cmake

@@ -244 +244 @@
 endif ()
 
+if (ENABLE_GAMEPAD_DEPRECATED)
+    # FIXME: GAMEPAD_DEPRECATED is legacy implementation. Need to be removed.
+    list(REMOVE_ITEM WebCore_INCLUDE_DIRECTORIES
+        "${WEBCORE_DIR}/Modules/gamepad"
+    )
+endif ()
+
 list(APPEND WebCore_USER_AGENT_STYLE_SHEETS
     ${WEBCORE_DIR}/Modules/mediacontrols/mediaControlsApple.css

trunk/Source/cmake/OptionsEfl.cmake

@@ -73 +73 @@
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FULLSCREEN_API ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_GAMEPAD OFF)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_GAMEPAD_DEPRECATED OFF)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_GAMEPAD_DEPRECATED ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_GEOLOCATION ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INDEXED_DATABASE OFF)