Changeset 172894 in webkit

Timestamp:

Aug 24, 2014 2:12:59 AM (10 years ago)

Author:

ryuan.choi@samsung.com

Message:

[EFL] Introduce DEVELOPER_MODE
​https://bugs.webkit.org/show_bug.cgi?id=135884

Reviewed by Gyuyoung Kim.

.:

Like GTK port, DEVELOPER_MODE can be good solution for developing, debugging and testing
instead of SHARED_CORE.
SHARED_CORE can reduce link time and memory consumption but it is slightly different
from release binary.

• Source/cmake/OptionsEfl.cmake:
• Source/cmake/WebKitHelpers.cmake:

Moved fvisibility=hidden to OptionsEfl.cmake

Tools:

• Scripts/webkitdirs.pm: Turn on DEVELOPER_MODE for the EFL port.

(generateBuildSystemFromCMakeProject):

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• Source/cmake/OptionsEfl.cmake (modified) (2 diffs)
• Source/cmake/WebKitHelpers.cmake (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/Scripts/webkitdirs.pm (modified) (1 diff)

trunk/ChangeLog

@@ +1 @@
+2014-08-24  Ryuan Choi  <ryuan.choi@samsung.com>
+
+        [EFL] Introduce DEVELOPER_MODE
+        https://bugs.webkit.org/show_bug.cgi?id=135884
+
+        Reviewed by Gyuyoung Kim.
+
+        Like GTK port, DEVELOPER_MODE can be good solution for developing, debugging and testing
+        instead of SHARED_CORE.
+        SHARED_CORE can reduce link time and memory consumption but it is slightly different
+        from release binary.
+
+        * Source/cmake/OptionsEfl.cmake:
+        * Source/cmake/WebKitHelpers.cmake:
+        Moved fvisibility=hidden to OptionsEfl.cmake
+
 2014-08-22  KwangHyuk Kim  <hyuki.kim@samsung.com>
 

trunk/Source/cmake/OptionsEfl.cmake

@@ -48 +48 @@
                 -DTEST_THEME_DIR="${THEME_BINARY_DIR}")
 
-set(WEBKIT2_VERSION_SCRIPT "-Wl,--version-script,${CMAKE_MODULE_PATH}/eflsymbols.filter")
-
 WEBKIT_OPTION_BEGIN()
+
+if (DEVELOPER_MODE)
+    set(ENABLE_TOOLS ON)
+    WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_API_TESTS ON)
+else ()
+    set(ENABLE_TOOLS OFF)
+    WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_API_TESTS OFF)
+
+    set(WEBKIT2_VERSION_SCRIPT "-Wl,--version-script,${CMAKE_MODULE_PATH}/eflsymbols.filter")
+endif ()
+
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_3D_RENDERING ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ACCESSIBILITY ON)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_API_TESTS ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_BATTERY_STATUS ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS3_CONDITIONAL_RULES ON)
@@ -283 +291 @@
 endif ()
 
+# FIXME: Consider to use linker script
+if (NOT SHARED_CORE AND NOT DEVELOPER_MODE)
+    set(CMAKE_C_FLAGS_RELEASE "-fvisibility=hidden ${CMAKE_C_FLAGS_RELEASE}")
+    set(CMAKE_CXX_FLAGS_RELEASE "-fvisibility=hidden ${CMAKE_CXX_FLAGS_RELEASE}")
+endif ()
+
 if (ENABLE_SPELLCHECK)
     find_package(Enchant REQUIRED)

trunk/Source/cmake/WebKitHelpers.cmake

@@ -17 +17 @@
         else ()
             EXEC_PROGRAM("${CMAKE_CXX_COMPILER} -E -Wp,-dM - < /dev/null | grep '#define __VERSION__' | grep -E -o '[0-9]+\\.[0-9]+\\.?[0-9]+?'" OUTPUT_VARIABLE COMPILER_VERSION)
-        endif ()
-
-        # For GTK+ we will rely on a linker script to deal with symbol visibility on
-        # production builds, we want all symbols visible for development builds.
-        if (NOT SHARED_CORE AND NOT ${PORT} STREQUAL "GTK")
-            set(OLD_COMPILE_FLAGS "-fvisibility=hidden ${OLD_COMPILE_FLAGS}")
         endif ()
 

trunk/Tools/ChangeLog

@@ +1 @@
+2014-08-24  Ryuan Choi  <ryuan.choi@samsung.com>
+
+        [EFL] Introduce DEVELOPER_MODE
+        https://bugs.webkit.org/show_bug.cgi?id=135884
+
+        Reviewed by Gyuyoung Kim.
+
+        * Scripts/webkitdirs.pm: Turn on DEVELOPER_MODE for the EFL port.
+        (generateBuildSystemFromCMakeProject):
+
 2014-08-24  Alexey Proskuryakov  <ap@apple.com>
 

trunk/Tools/Scripts/webkitdirs.pm

@@ -1943 +1943 @@
 
     # GTK+ has a production mode, but build-webkit should always use developer mode.
-    push @args, "-DDEVELOPER_MODE=ON" if isGtk();
+    push @args, "-DDEVELOPER_MODE=ON" if isEfl() || isGtk();
 
     # Don't warn variables which aren't used by cmake ports.