Changeset 172951 in webkit

Timestamp:

Aug 25, 2014 11:43:16 PM (10 years ago)

Author:

gyuyoung.kim@samsung.com

Message:

Generate toFile() instead of manual functions.
​https://bugs.webkit.org/show_bug.cgi?id=136207

Reviewed by Darin Adler.

No new tests, no behavior changes.

• fileapi/Blob.h: Define BLOB_TYPE_CASTS.
• fileapi/File.h: Use BLOB_TYPE_CASTS to generate toFile().

(WebCore::toFile): Deleted.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• fileapi/Blob.h (modified) (1 diff)
• fileapi/File.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-08-25  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
+
+        Generate toFile() instead of manual functions.
+        https://bugs.webkit.org/show_bug.cgi?id=136207
+
+        Reviewed by Darin Adler.
+
+        No new tests, no behavior changes.
+
+        * fileapi/Blob.h: Define BLOB_TYPE_CASTS.
+        * fileapi/File.h: Use BLOB_TYPE_CASTS to generate toFile().
+        (WebCore::toFile): Deleted.
+
 2014-08-25  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/fileapi/Blob.h

@@ -113 +113 @@
 };
 
+#define BLOB_TYPE_CASTS(ToValueTypeName, predicate) \
+    TYPE_CASTS_BASE(ToValueTypeName, Blob, object, blob->predicate, blob.predicate)
+
 } // namespace WebCore
 

trunk/Source/WebCore/fileapi/File.h

@@ -84 +84 @@
 };
 
-inline File* toFile(Blob* blob)
-{
-    ASSERT_WITH_SECURITY_IMPLICATION(!blob || blob->isFile());
-    return static_cast<File*>(blob);
-}
-
-inline const File* toFile(const Blob* blob)
-{
-    ASSERT_WITH_SECURITY_IMPLICATION(!blob || blob->isFile());
-    return static_cast<const File*>(blob);
-}
+BLOB_TYPE_CASTS(File, isFile())
 
 } // namespace WebCore