Changeset 173211 in webkit


Ignore:
Timestamp:
Sep 3, 2014 10:57:25 AM (10 years ago)
Author:
dburkart@apple.com
Message:

Dashboard should show performance bots.
https://bugs.webkit.org/show_bug.cgi?id=136386

Reviewed by Alexey Proskuryakov.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:

(BuildbotIteration.prototype._parseData.collectPerfTestResults):
(BuildbotIteration.prototype._parseData):
Support possible performance failures.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:

New QueueView to manage the way we present performance data.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:

(BuildbotQueue):
Support new 'performance' and 'performanceTestName' keys.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:

Add performance column to the main page.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:

(body):
Make sure everything fits on 13 inch screens.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
Location:
trunk/Tools
Files:
1 added
7 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js

    r173027 r173211  
    8080    "webkitperl-test": 1,
    8181    "bindings-generation-tests": 1,
     82    "run Membuster OS Memory": 1,
     83    "run scrollperf": 1,
     84    "run PLT3": 1,
     85    "perf-test": 1
    8286};
    8387
     
    195199            testResults.finished = true;
    196200
    197             if (!testStep.results || !testStep.results[0]) {
     201            if (!testStep.results || testStep.results[0] === BuildbotIteration.SUCCESS) {
    198202                // All tests passed.
    199203                testResults.allPassed = true;
  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js

    r172998 r173211  
    3939    this.builder = info.builder || false;
    4040    this.tester = info.tester || false;
     41    this.performance = info.performance || false;
    4142    this.architecture = info.architecture || null;
    4243    this.testCategory = info.testCategory || null;
     44    this.performanceTestName = info.performanceTestName || null;
    4345
    4446    this.iterations = [];
  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js

    r172996 r173211  
    4444        } else if (queue.tester) {
    4545            categoryName = queue.testCategory;
     46        } else if (queue.performance) {
     47            categoryName = "performance";
    4648        } else {
    4749            console.assert("Unknown queue type.");
     
    149151    }
    150152
     153    var header = document.createElement("th");
     154    header.textContent = "Performance";
     155    row.appendChild(header);
     156
    151157    if (hasEWS) {
    152158        var header = document.createElement("th");
     
    207213        }
    208214
     215        var cell = document.createElement("td");
     216        if (platformQueues.performance && platformQueues.performance.release) {
     217            var view = new BuildbotPerformanceQueueView(platformQueues.performance.release);
     218            cell.appendChild(view.element);
     219        }
     220
     221        row.appendChild(cell);
     222
    209223        if (hasEWS) {
    210224            var cell = document.createElement("td");
  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js

    r170741 r173211  
    3434        "Apple MountainLion Release WK2 (Tests)": {platform: Dashboard.Platform.MacOSXMountainLion, tester: true, testCategory: Buildbot.TestCategory.WebKit2},
    3535        "Apple MountainLion Debug WK2 (Tests)": {platform: Dashboard.Platform.MacOSXMountainLion, debug: true, tester: true, testCategory: Buildbot.TestCategory.WebKit2},
     36        "Apple MountainLion Release (Perf)": {platform: Dashboard.Platform.MacOSXMountainLion, debug: false, performance: true},
    3637        "Apple Mavericks Debug (Build)": {platform: Dashboard.Platform.MacOSXMavericks, debug: true, builder: true, architecture: Buildbot.BuildArchitecture.SixtyFourBit},
    3738        "Apple Mavericks Release (Build)": {platform: Dashboard.Platform.MacOSXMavericks, debug: false, builder: true, architecture: Buildbot.BuildArchitecture.SixtyFourBit},
     
    4041        "Apple Mavericks Release WK1 (Tests)": {platform: Dashboard.Platform.MacOSXMavericks, debug: false, tester: true, testCategory: Buildbot.TestCategory.WebKit1},
    4142        "Apple Mavericks Release WK2 (Tests)": {platform: Dashboard.Platform.MacOSXMavericks, debug: false, tester: true, testCategory: Buildbot.TestCategory.WebKit2},
     43        "Apple Mavericks Release (Perf)": {platform: Dashboard.Platform.MacOSXMavericks, debug: false, performance: true},
    4244        "Apple Win Debug (Build)": {platform: Dashboard.Platform.Windows7, debug: true, builder: true, architecture: Buildbot.BuildArchitecture.ThirtyTwoBit},
    4345        "Apple Win Release (Build)": {platform: Dashboard.Platform.Windows7, builder: true, architecture: Buildbot.BuildArchitecture.ThirtyTwoBit},
     
    4850        "GTK Linux 64-bit Debug (Build)": {platform: Dashboard.Platform.LinuxGTK, debug: true, builder: true, architecture: Buildbot.BuildArchitecture.SixtyFourBit},
    4951        "GTK Linux 64-bit Debug (Tests)": {platform: Dashboard.Platform.LinuxGTK, debug: true, tester: true, testCategory: Buildbot.TestCategory.WebKit2},
    50         "EFL Linux 64-bit Release WK2": {platform: Dashboard.Platform.LinuxEFL, tester: true, testCategory: Buildbot.TestCategory.WebKit2}
     52        "GTK Linux 64-bit Release (Perf)": {platform: Dashboard.Platform.LinuxGTK, debug: false, performance: true},
     53        "EFL Linux 64-bit Release WK2": {platform: Dashboard.Platform.LinuxEFL, tester: true, testCategory: Buildbot.TestCategory.WebKit2},
     54        "EFL Linux 64-bit Release WK2 (Perf)": {platform: Dashboard.Platform.LinuxEFL, performance: true}
    5155    };
    5256
     
    5963    constructor: WebKitBuildbot,
    6064    __proto__: Buildbot.prototype,
     65    performanceDashboardURL:  "https://perf.webkit.org",
    6166
    6267    layoutTestResultsDirectoryURLForIteration: function(iteration)
  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css

    r173008 r173211  
    9090    background-color: rgb(233, 231, 223);
    9191    text-align: center;
    92     margin: 50px;
     92    margin: 50px 25px 50px 25px;
    9393}
    9494
  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html

    r162373 r173211  
    5151    <script src="Scripts/BuildbotBuilderQueueView.js"></script>
    5252    <script src="Scripts/BuildbotTesterQueueView.js"></script>
     53    <script src="Scripts/BuildbotPerformanceQueueView.js"></script>
    5354    <script src="Scripts/EWSQueueView.js"></script>
    5455    <script src="Scripts/StatusLineView.js"></script>
  • trunk/Tools/ChangeLog

    r173201 r173211  
     12014-09-03  Dana Burkart  <dburkart@apple.com>
     2
     3        Dashboard should show performance bots.
     4        https://bugs.webkit.org/show_bug.cgi?id=136386
     5
     6        Reviewed by Alexey Proskuryakov.
     7
     8        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
     9        (BuildbotIteration.prototype._parseData.collectPerfTestResults):
     10        (BuildbotIteration.prototype._parseData):
     11        Support possible performance failures.
     12
     13        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
     14        New QueueView to manage the way we present performance data.
     15
     16        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
     17        (BuildbotQueue):
     18        Support new 'performance' and 'performanceTestName' keys.
     19
     20
     21        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
     22        Add performance column to the main page.
     23
     24        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
     25        (WebKitBuildbot):
     26        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
     27        (body):
     28        Make sure everything fits on 13 inch screens.
     29
     30        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
     31
    1322014-09-03  Zan Dobersek  <zdobersek@igalia.com>
    233
Note: See TracChangeset for help on using the changeset viewer.