Changeset 173458 in webkit
- Timestamp:
- Sep 10, 2014 6:23:42 AM (10 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 9 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r173457 r173458 1 2014-09-10 Gyuyoung Kim <gyuyoung.kim@samsung.com> 2 3 Use toDocument instead of static_cast<Document*> 4 https://bugs.webkit.org/show_bug.cgi?id=136694 5 6 Reviewed by Andy Estes. 7 8 Clean up static_cast<Document*>. 9 10 * Modules/mediasource/SourceBuffer.cpp: 11 (WebCore::SourceBuffer::document): 12 * Modules/webaudio/AudioContext.cpp: 13 (WebCore::AudioContext::document): 14 * bindings/gobject/WebKitDOMPrivate.cpp: 15 (WebKit::wrap): 16 * dom/ScriptExecutionContext.cpp: 17 (WebCore::ScriptExecutionContext::dispatchErrorEvent): Add a line to remove .get(). 18 * workers/DefaultSharedWorkerRepository.cpp: 19 (WebCore::SharedWorkerProxy::addToWorkerDocuments): 20 * workers/WorkerMessagingProxy.cpp: 21 (WebCore::WorkerMessagingProxy::startWorkerGlobalScope): 22 * xml/XMLHttpRequest.cpp: 23 (WebCore::XMLHttpRequest::document): 24 (WebCore::XMLHttpRequest::open): 25 1 26 2014-09-10 Yusuke Suzuki <utatane.tea@gmail.com> 2 27 -
trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp
r173318 r173458 1796 1796 Document& SourceBuffer::document() const 1797 1797 { 1798 ASSERT(scriptExecutionContext() ->isDocument());1799 return * static_cast<Document*>(scriptExecutionContext());1798 ASSERT(scriptExecutionContext()); 1799 return *toDocument(scriptExecutionContext()); 1800 1800 } 1801 1801 -
trunk/Source/WebCore/Modules/webaudio/AudioContext.cpp
r163725 r173458 325 325 Document* AudioContext::document() const 326 326 { 327 ASSERT(m_scriptExecutionContext && m_scriptExecutionContext->isDocument());328 return static_cast<Document*>(m_scriptExecutionContext);327 ASSERT(m_scriptExecutionContext); 328 return toDocument(m_scriptExecutionContext); 329 329 } 330 330 -
trunk/Source/WebCore/bindings/gobject/WebKitDOMPrivate.cpp
r167874 r173458 101 101 return WEBKIT_DOM_NODE(wrapComment(static_cast<Comment*>(node))); 102 102 case Node::DOCUMENT_NODE: 103 if ( static_cast<Document*>(node)->isHTMLDocument())103 if (toDocument(node)->isHTMLDocument()) 104 104 return WEBKIT_DOM_NODE(wrapHTMLDocument(static_cast<HTMLDocument*>(node))); 105 return WEBKIT_DOM_NODE(wrapDocument( static_cast<Document*>(node)));105 return WEBKIT_DOM_NODE(wrapDocument(toDocument(node))); 106 106 case Node::DOCUMENT_TYPE_NODE: 107 107 return WEBKIT_DOM_NODE(wrapDocumentType(static_cast<DocumentType*>(node))); -
trunk/Source/WebCore/dom/ScriptExecutionContext.cpp
r173208 r173458 380 380 #if PLATFORM(IOS) 381 381 if (target == target->toDOMWindow() && isDocument()) { 382 Settings* settings = static_cast<Document*>(this)->settings();382 Settings* settings = toDocument(this)->settings(); 383 383 if (settings && !settings->shouldDispatchJavaScriptWindowOnErrorEvents()) 384 384 return false; -
trunk/Source/WebCore/dom/ScriptExecutionContext.h
r173133 r173458 236 236 237 237 #define SCRIPT_EXECUTION_CONTEXT_TYPE_CASTS(ToValueTypeName) \ 238 template<typename T> inline ToValueTypeName* to##ToValueTypeName(const RefPtr<T>& context) { return to##ToValueTypeName(context.get()); } \ 238 239 TYPE_CASTS_BASE(ToValueTypeName, ScriptExecutionContext, context, context->is##ToValueTypeName(), context.is##ToValueTypeName()) 239 240 -
trunk/Source/WebCore/workers/DefaultSharedWorkerRepository.cpp
r170774 r173458 226 226 { 227 227 // Nested workers are not yet supported, so passed-in context should always be a Document. 228 ASSERT_WITH_SECURITY_IMPLICATION(context ->isDocument());228 ASSERT_WITH_SECURITY_IMPLICATION(context); 229 229 ASSERT(!isClosing()); 230 230 MutexLocker lock(m_workerDocumentsLock); 231 Document* document = static_cast<Document*>(context); 232 m_workerDocuments.add(document); 231 m_workerDocuments.add(toDocument(context)); 233 232 } 234 233 -
trunk/Source/WebCore/workers/WorkerMessagingProxy.cpp
r170774 r173458 83 83 { 84 84 // FIXME: This need to be revisited when we support nested worker one day 85 ASSERT_WITH_SECURITY_IMPLICATION(m_scriptExecutionContext ->isDocument());86 Document* document = static_cast<Document*>(m_scriptExecutionContext.get());85 ASSERT_WITH_SECURITY_IMPLICATION(m_scriptExecutionContext); 86 Document* document = toDocument(m_scriptExecutionContext); 87 87 GroupSettings* settings = 0; 88 88 if (document->page()) -
trunk/Source/WebCore/xml/XMLHttpRequest.cpp
r173254 r173458 155 155 Document* XMLHttpRequest::document() const 156 156 { 157 ASSERT_WITH_SECURITY_IMPLICATION(scriptExecutionContext() ->isDocument());158 return static_cast<Document*>(scriptExecutionContext());157 ASSERT_WITH_SECURITY_IMPLICATION(scriptExecutionContext()); 158 return toDocument(scriptExecutionContext()); 159 159 } 160 160 … … 489 489 bool shouldBypassMainWorldContentSecurityPolicy = false; 490 490 if (scriptExecutionContext()->isDocument()) { 491 Document* document = static_cast<Document*>(scriptExecutionContext());491 Document* document = toDocument(scriptExecutionContext()); 492 492 if (document->frame()) 493 493 shouldBypassMainWorldContentSecurityPolicy = document->frame()->script().shouldBypassMainWorldContentSecurityPolicy();
Note: See TracChangeset
for help on using the changeset viewer.