Changeset 173494 in webkit
- Timestamp:
- Sep 10, 2014 3:41:20 PM (10 years ago)
- Location:
- trunk/Source/WebInspectorUI
- Files:
-
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebInspectorUI/ChangeLog
r173492 r173494 1 2014-09-10 Joseph Pecoraro <pecoraro@apple.com> 2 3 Web Inspector: Eliminate typeof "undefined" checks 4 https://bugs.webkit.org/show_bug.cgi?id=136691 5 6 Reviewed by Alexey Proskuryakov. 7 8 * UserInterface/Base/Main.js: 9 (WebInspector.linkifyURLAsNode): 10 (WebInspector.linkifyStringAsFragment): 11 * UserInterface/Protocol/InspectorBackend.js: 12 (InspectorBackend.Command.prototype._invokeWithArguments): 13 * UserInterface/Views/DataGrid.js: 14 (WebInspector.DataGrid.prototype.get resizeMethod): 15 * UserInterface/Views/NavigationBar.js: 16 (WebInspector.NavigationBar.prototype.get minimumWidth): 17 1 18 2014-09-10 Joseph Pecoraro <pecoraro@apple.com> 2 19 -
trunk/Source/WebInspectorUI/UserInterface/Base/Main.js
r173407 r173494 1627 1627 a.className = classes; 1628 1628 1629 if (t ypeof tooltipText === "undefined")1629 if (tooltipText === undefined) 1630 1630 a.title = url; 1631 1631 else if (typeof tooltipText !== "string" || tooltipText.length) … … 1676 1676 { 1677 1677 var urlNode = WebInspector.linkifyURLAsNode(url, title, undefined); 1678 if ( typeof(lineNumber) !== "undefined")1678 if (lineNumber !== undefined) 1679 1679 urlNode.lineNumber = lineNumber; 1680 1680 -
trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js
r172158 r173494 431 431 432 432 var value = commandArguments.shift(); 433 if (optionalFlag && typeof value === "undefined")433 if (optionalFlag && value === undefined) 434 434 continue; 435 435 … … 443 443 444 444 if (commandArguments.length === 1 && !callback) { 445 if ( typeof commandArguments[0] !== "undefined") {445 if (commandArguments[0] !== undefined) { 446 446 console.error("Protocol Error: Optional callback argument for method '" + instance.qualifiedName + "' call must be a function but its type is '" + typeof args[0] + "'."); 447 447 return; -
trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js
r173433 r173494 415 415 416 416 insertColumn: function(columnIdentifier, columnData, insertionIndex) { 417 if ( typeof insertionIndex === "undefined")417 if (insertionIndex === undefined) 418 418 insertionIndex = this.orderedColumns.length; 419 419 insertionIndex = Number.constrain(insertionIndex, 0, this.orderedColumns.length); … … 1218 1218 get resizeMethod() 1219 1219 { 1220 if ( typeof this._resizeMethod === "undefined")1220 if (!this._resizeMethod) 1221 1221 return WebInspector.DataGrid.ResizeMethod.Nearest; 1222 1222 return this._resizeMethod; -
trunk/Source/WebInspectorUI/UserInterface/Views/NavigationBar.js
r173477 r173494 234 234 get minimumWidth() 235 235 { 236 if (t ypeof this._minimumWidth === "undefined"|| this._minimumWidthNeedsRecalculation) {236 if (this._minimumWidth === undefined || this._minimumWidthNeedsRecalculation) { 237 237 this._minimumWidth = this._calculateMinimumWidth(); 238 238 delete this._minimumWidthNeedsRecalculation;
Note: See TracChangeset
for help on using the changeset viewer.