Changeset 173503 in webkit

Timestamp:

Sep 10, 2014 6:25:46 PM (10 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL][WK2] Minibrowser : Add tooltip for toolbar buttons in Minibrowser
​https://bugs.webkit.org/show_bug.cgi?id=136284

Patch by Rohit Kumar <​kumar.rohit@samsung.com> on 2014-09-10
Reviewed by Gyuyoung Kim.

• MiniBrowser/efl/main.c:

(window_create):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• MiniBrowser/efl/main.c (modified) (5 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2014-09-10  Rohit Kumar  <kumar.rohit@samsung.com>
+
+        [EFL][WK2] Minibrowser : Add tooltip for toolbar buttons in Minibrowser
+        https://bugs.webkit.org/show_bug.cgi?id=136284
+
+        Reviewed by Gyuyoung Kim.
+
+        * MiniBrowser/efl/main.c:
+        (window_create):
+
 2014-09-10  Rebecca Hauck  <rhauck@adobe.com>
 

trunk/Tools/MiniBrowser/efl/main.c

@@ -1961 +1961 @@
     evas_object_smart_callback_add(window->back_button, "clicked", on_back_button_clicked, window);
     evas_object_smart_callback_add(window->back_button, "repeated", on_back_button_longpress, window);
+    elm_object_tooltip_text_set(window->back_button, "Click to go back, longpress to see session history");
+    elm_object_tooltip_window_mode_set(window->back_button, EINA_TRUE);
     elm_object_disabled_set(window->back_button, EINA_TRUE);
     evas_object_size_hint_weight_set(window->back_button, 0.0, EVAS_HINT_EXPAND);
@@ -1971 +1973 @@
     evas_object_smart_callback_add(window->forward_button, "clicked", on_forward_button_clicked, window);
     evas_object_smart_callback_add(window->forward_button, "repeated", on_forward_button_longpress, window);
+    elm_object_tooltip_text_set(window->forward_button, "Click to go forward, longpress to see session history");
+    elm_object_tooltip_window_mode_set(window->forward_button, EINA_TRUE);
     elm_object_disabled_set(window->forward_button, EINA_TRUE);
     evas_object_size_hint_weight_set(window->forward_button, 0.0, EVAS_HINT_EXPAND);
@@ -1994 +1998 @@
     Evas_Object *refresh_button = create_toolbar_button(window->elm_window, "refresh");
     evas_object_smart_callback_add(refresh_button, "clicked", on_refresh_button_clicked, window);
+    elm_object_tooltip_text_set(refresh_button, "Reload page");
+    elm_object_tooltip_window_mode_set(refresh_button, EINA_TRUE);
     evas_object_size_hint_weight_set(refresh_button, 0.0, EVAS_HINT_EXPAND);
     evas_object_size_hint_align_set(refresh_button, 1.0, 0.5);
@@ -2002 +2008 @@
     Evas_Object *stop_button = create_toolbar_button(window->elm_window, "close");
     evas_object_smart_callback_add(stop_button, "clicked", on_stop_button_clicked, window);
+    elm_object_tooltip_text_set(stop_button, "Stop page load");
+    elm_object_tooltip_window_mode_set(stop_button, EINA_TRUE);
     evas_object_size_hint_weight_set(stop_button, 0.0, EVAS_HINT_EXPAND);
     evas_object_size_hint_align_set(stop_button, 1.0, 0.5);
@@ -2010 +2018 @@
     Evas_Object *home_button = create_toolbar_button(window->elm_window, "home");
     evas_object_smart_callback_add(home_button, "clicked", on_home_button_clicked, window);
+    elm_object_tooltip_text_set(home_button, "Home page");
+    elm_object_tooltip_window_mode_set(home_button, EINA_TRUE);
     evas_object_size_hint_weight_set(home_button, 0.0, EVAS_HINT_EXPAND);
     evas_object_size_hint_align_set(home_button, 1.0, 0.5);