Changeset 173515 in webkit

Timestamp:

Sep 11, 2014 9:13:23 AM (10 years ago)

Author:

Chris Fleizach

Message:

AX: Children inside a <legend> are not accessible
​https://bugs.webkit.org/show_bug.cgi?id=136735

Reviewed by Mario Sanchez Prada.

Source/WebCore:

The AX children of a <legend> are being hidden currently, which makes it impossible for
VoiceOver to activate control elements inside of a <legend>.
The solution is that legend elements SHOULD be allowed to have children.

Test: accessibility/legend-children-are-visible.html

• accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::canHaveChildren):

LayoutTests:

• accessibility/legend-children-are-visible-expected.txt: Added.
• accessibility/legend-children-are-visible.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/accessibility/legend-children-are-visible-expected.txt (added)
• LayoutTests/accessibility/legend-children-are-visible.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/accessibility/AccessibilityNodeObject.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-09-11  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: Children inside a <legend> are not accessible
+        https://bugs.webkit.org/show_bug.cgi?id=136735
+
+        Reviewed by Mario Sanchez Prada.
+
+        * accessibility/legend-children-are-visible-expected.txt: Added.
+        * accessibility/legend-children-are-visible.html: Added.
+
 2014-09-11  Philippe Normand  <pnormand@igalia.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-09-11  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: Children inside a <legend> are not accessible
+        https://bugs.webkit.org/show_bug.cgi?id=136735
+
+        Reviewed by Mario Sanchez Prada.
+
+        The AX children of a <legend> are being hidden currently, which makes it impossible for
+        VoiceOver to activate control elements inside of a <legend>.
+        The solution is that legend elements SHOULD be allowed to have children.
+
+        Test: accessibility/legend-children-are-visible.html
+
+        * accessibility/AccessibilityNodeObject.cpp:
+        (WebCore::AccessibilityNodeObject::canHaveChildren):
+
 2014-09-11  Brendan Long  <b.long@cablelabs.com>
 

trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp

@@ -401 +401 @@
     case ProgressIndicatorRole:
         return false;
-    case LegendRole:
-        if (Element* element = this->element())
-            return !ancestorsOfType<HTMLFieldSetElement>(*element).first();
-        FALLTHROUGH;
     default:
         return true;