Changeset 173860 in webkit

Timestamp:

Sep 22, 2014 6:05:55 PM (10 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL][WK2] Minibrowser : Add keyboard support for page reload while ignoring cache
​https://bugs.webkit.org/show_bug.cgi?id=136813

Patch by Rohit Kumar <​kumar.rohit@samsung.com> on 2014-09-22
Reviewed by Gyuyoung Kim.

Ctrl+r is used for page reload along with F5. Ctrl+Shift+r and Ctrl+F5 is used for page reload while ignoring cache.

• MiniBrowser/efl/main.c:

(on_key_down):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• MiniBrowser/efl/main.c (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2014-09-22  Rohit Kumar  <kumar.rohit@samsung.com>
+
+        [EFL][WK2] Minibrowser : Add keyboard support for page reload while ignoring cache
+        https://bugs.webkit.org/show_bug.cgi?id=136813
+
+        Reviewed by Gyuyoung Kim.
+
+        Ctrl+r is used for page reload along with F5. Ctrl+Shift+r and Ctrl+F5 is used for page reload while ignoring cache.
+
+        * MiniBrowser/efl/main.c:
+        (on_key_down):
+
 2014-09-22  Daniel Bates  <dabates@apple.com>
 

trunk/Tools/MiniBrowser/efl/main.c

@@ -523 +523 @@
     Eina_Bool ctrlPressed = evas_key_modifier_is_set(mod, "Control");
     Eina_Bool altPressed = evas_key_modifier_is_set(mod, "Alt");
+    Eina_Bool shiftPressed = evas_key_modifier_is_set(mod, "Shift");
 
     if (!strcmp(ev->key, "Left") && altPressed) {
@@ -539 +540 @@
         info("Set encoding (F3) pressed. New encoding to %s", encodings[currentEncoding]);
         ewk_view_custom_encoding_set(ewk_view, encodings[currentEncoding]);
-    } else if (!strcmp(ev->key, "F5")) {
-        info("Reload (F5) was pressed, reloading.");
+    } else if ((!strcmp(ev->key, "F5") && ctrlPressed) || (!strcmp(ev->key, "r") && (shiftPressed & ctrlPressed))) {
+        info("Reload ignoring cache (Ctrl+F5 or Ctrl+Shift+r) was pressed, reloading and bypassing cache...");
+        ewk_view_reload_bypass_cache(ewk_view);
+    } else if (!strcmp(ev->key, "F5") || (!strcmp(ev->key, "r") && ctrlPressed)) {
+        info("Reload (F5 or Ctrl+r) was pressed, reloading...");
         ewk_view_reload(ewk_view);
     } else if (!strcmp(ev->key, "F6") || !strcmp(ev->key, "Escape")) {