Changeset 173867 in webkit

Timestamp:

Sep 23, 2014 12:47:21 AM (10 years ago)

Author:

Ion Rosca

Message:

[CSS Blending] The composited layers isolated by the page group should blend with the default white background color.
​https://bugs.webkit.org/show_bug.cgi?id=136563

Reviewed by Simon Fraser.

Source/WebCore:

If a blending layer is not isolated, then it should blend with a white backdrop:
​http://dev.w3.org/fxtf/compositing-1/#pagebackdrop

Tests: css3/blending/blend-mode-body-composited-child-background-color.html

css3/blending/blend-mode-body-composited-child.html

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
If the isolating composited layer is the root renderer, then it should have a backing store
into which the initial white backdrop will be painted.

LayoutTests:

• css3/blending/blend-mode-blended-element-overlapping-composited-sibling-should-have-compositing-layer-expected.txt:
• css3/blending/blend-mode-body-composited-child-background-color-expected.html: Added.
• css3/blending/blend-mode-body-composited-child-background-color.html: Added.
• css3/blending/blend-mode-body-composited-child-expected.html: Added.
• css3/blending/blend-mode-body-composited-child.html: Added.
• css3/blending/blend-mode-parent-of-composited-blended-has-layer-expected.txt:
• css3/blending/blend-mode-with-composited-descendant-should-have-layer-expected.txt:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/css3/blending/blend-mode-blended-element-overlapping-composited-sibling-should-have-compositing-layer-expected.txt (modified) (1 diff)
• LayoutTests/css3/blending/blend-mode-body-composited-child-background-color-expected.html (added)
• LayoutTests/css3/blending/blend-mode-body-composited-child-background-color.html (added)
• LayoutTests/css3/blending/blend-mode-body-composited-child-expected.html (added)
• LayoutTests/css3/blending/blend-mode-body-composited-child.html (added)
• LayoutTests/css3/blending/blend-mode-parent-of-composited-blended-has-layer-expected.txt (modified) (1 diff)
• LayoutTests/css3/blending/blend-mode-with-composited-descendant-should-have-layer-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderLayerBacking.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-09-23  Ion Rosca  <rosca@adobe.com>
+
+        [CSS Blending] The composited layers isolated by the page group should blend with the default white background color.
+        https://bugs.webkit.org/show_bug.cgi?id=136563
+
+        Reviewed by Simon Fraser.
+
+        * css3/blending/blend-mode-blended-element-overlapping-composited-sibling-should-have-compositing-layer-expected.txt:
+        * css3/blending/blend-mode-body-composited-child-background-color-expected.html: Added.
+        * css3/blending/blend-mode-body-composited-child-background-color.html: Added.
+        * css3/blending/blend-mode-body-composited-child-expected.html: Added.
+        * css3/blending/blend-mode-body-composited-child.html: Added.
+        * css3/blending/blend-mode-parent-of-composited-blended-has-layer-expected.txt:
+        * css3/blending/blend-mode-with-composited-descendant-should-have-layer-expected.txt:
+
 2014-09-22  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 

trunk/LayoutTests/css3/blending/blend-mode-blended-element-overlapping-composited-sibling-should-have-compositing-layer-expected.txt

@@ -9 +9 @@
         (GraphicsLayer
           (bounds 800.00 600.00)
+          (drawsContent 1)
           (children 2
             (GraphicsLayer

trunk/LayoutTests/css3/blending/blend-mode-parent-of-composited-blended-has-layer-expected.txt

@@ -9 +9 @@
         (GraphicsLayer
           (bounds 800.00 600.00)
+          (drawsContent 1)
           (children 1
             (GraphicsLayer

trunk/LayoutTests/css3/blending/blend-mode-with-composited-descendant-should-have-layer-expected.txt

@@ -9 +9 @@
         (GraphicsLayer
           (bounds 800.00 600.00)
+          (drawsContent 1)
           (children 1
             (GraphicsLayer

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-09-23  Ion Rosca  <rosca@adobe.com>
+
+        [CSS Blending] The composited layers isolated by the page group should blend with the default white background color.
+        https://bugs.webkit.org/show_bug.cgi?id=136563
+
+        Reviewed by Simon Fraser.
+
+        If a blending layer is not isolated, then it should blend with a white backdrop:
+        http://dev.w3.org/fxtf/compositing-1/#pagebackdrop
+
+        Tests: css3/blending/blend-mode-body-composited-child-background-color.html
+               css3/blending/blend-mode-body-composited-child.html
+
+        * rendering/RenderLayerBacking.cpp:
+        (WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
+        If the isolating composited layer is the root renderer, then it should have a backing store
+        into which the initial white backdrop will be painted.
+
 2014-09-22  Christophe Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/rendering/RenderLayerBacking.cpp

@@ -1707 +1707 @@
         return false;
 
+    if (renderer().isRoot() && m_owningLayer.isolatesCompositedBlending())
+        return false;
+
     if (renderer().isRenderView()) {
         // Look to see if the root object has a non-simple background