Changeset 174002 in webkit


Ignore:
Timestamp:
Sep 26, 2014 1:39:59 AM (10 years ago)
Author:
commit-queue@webkit.org
Message:

[GTK] Fix support for the initial-letter CSS property to first-letter
​https://bugs.webkit.org/show_bug.cgi?id=137108

Patch by Lorenzo Tilve <​ltilve@igalia.com> on 2014-09-26
Reviewed by Alejandro G. Castro.

Source/WebCore:

Add support for cap-height to the font system.

  • platform/graphics/freetype/SimpleFontDataFreeType.cpp:

(WebCore::SimpleFontData::platformInit):

LayoutTests:

Add missing GTK test expectation files after ​http://webkit.org/b/136484

  • platform/gtk/fast/css-generated-content/initial-letter-basic-expected.txt: Added.
  • platform/gtk/fast/css-generated-content/initial-letter-border-padding-expected.txt: Added.
  • platform/gtk/fast/css-generated-content/initial-letter-clearance-expected.txt: Added.
  • platform/gtk/fast/css-generated-content/initial-letter-descender-expected.txt: Added.
  • platform/gtk/fast/css-generated-content/initial-letter-raised-expected.txt: Added.
  • platform/gtk/fast/css-generated-content/initial-letter-sunken-expected.txt: Added.
Location:
trunk
Files:
6 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r173998 r174002  
     12014-09-26  Lorenzo Tilve  <ltilve@igalia.com>
     2
     3        [GTK] Fix support for the initial-letter CSS property to first-letter
     4        https://bugs.webkit.org/show_bug.cgi?id=137108
     5
     6        Reviewed by Alejandro G. Castro.
     7
     8        Add missing GTK test expectation files after http://webkit.org/b/136484
     9
     10        * platform/gtk/fast/css-generated-content/initial-letter-basic-expected.txt: Added.
     11        * platform/gtk/fast/css-generated-content/initial-letter-border-padding-expected.txt: Added.
     12        * platform/gtk/fast/css-generated-content/initial-letter-clearance-expected.txt: Added.
     13        * platform/gtk/fast/css-generated-content/initial-letter-descender-expected.txt: Added.
     14        * platform/gtk/fast/css-generated-content/initial-letter-raised-expected.txt: Added.
     15        * platform/gtk/fast/css-generated-content/initial-letter-sunken-expected.txt: Added.
     16
    1172014-09-26  Brian J. Burg  <burg@cs.washington.edu>
    218

  • trunk/Source/WebCore/ChangeLog

    r173992 r174002  
     12014-09-26  Lorenzo Tilve  <ltilve@igalia.com>
     2
     3        [GTK] Fix support for the initial-letter CSS property to first-letter
     4        https://bugs.webkit.org/show_bug.cgi?id=137108
     5
     6        Reviewed by Alejandro G. Castro.
     7
     8        Add support for cap-height to the font system.
     9
     10        * platform/graphics/freetype/SimpleFontDataFreeType.cpp:
     11        (WebCore::SimpleFontData::platformInit):
     12
    1132014-09-25  Brian J. Burg  <burg@cs.washington.edu>
    214

  • trunk/Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp

    r165676 r174002  
    6464    float ascent = narrowPrecisionToFloat(fontExtents.ascent);
    6565    float descent = narrowPrecisionToFloat(fontExtents.descent);
     66    float capHeight = narrowPrecisionToFloat(fontExtents.height);
    6667    float lineGap = narrowPrecisionToFloat(fontExtents.height - fontExtents.ascent - fontExtents.descent);
    6768
    6869    m_fontMetrics.setAscent(ascent);
    6970    m_fontMetrics.setDescent(descent);
     71    m_fontMetrics.setCapHeight(capHeight);
    7072
    7173#if PLATFORM(EFL)
Note: See TracChangeset for help on using the changeset viewer.