Changeset 174007 in webkit


Ignore:
Timestamp:
Sep 26, 2014 7:27:52 AM (10 years ago)
Author:
jfernandez@igalia.com
Message:

[CSS Grid Layout] Empty string case already covered by containesOnlyWhiteSpace.
https://bugs.webkit.org/show_bug.cgi?id=137146

Reviewed by Sergio Villar Senin.

When checking out for white-space only strings in the grid-template-areas
property values, it's not neccessary to check out for empty strings as
such case is already covered.

No new tests, already covered by fast/css-grid-layout/grid-template-areas-empty-string-crash.html.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseGridTemplateAreasRow):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r174006 r174007  
     12014-09-26  Javier Fernandez  <jfernandez@igalia.com>
     2
     3        [CSS Grid Layout] Empty string case already covered by containesOnlyWhiteSpace.
     4        https://bugs.webkit.org/show_bug.cgi?id=137146
     5
     6        Reviewed by Sergio Villar Senin.
     7
     8        When checking out for white-space only strings in the grid-template-areas
     9        property values, it's not neccessary to check out for empty strings as
     10        such case is already covered.
     11
     12        No new tests, already covered by fast/css-grid-layout/grid-template-areas-empty-string-crash.html.
     13
     14        * css/CSSParser.cpp:
     15        (WebCore::CSSParser::parseGridTemplateAreasRow):
     16
    1172014-09-23  Sergio Villar Senin  <svillar@igalia.com>
    218
  • trunk/Source/WebCore/css/CSSParser.cpp

    r173989 r174007  
    55705570
    55715571    String gridRowNames = currentValue->string;
    5572     if (gridRowNames.isEmpty() || gridRowNames.containsOnlyWhitespace())
     5572    if (gridRowNames.containsOnlyWhitespace())
    55735573        return false;
    55745574
Note: See TracChangeset for help on using the changeset viewer.