Changeset 17444 in webkit


Ignore:
Timestamp:
Oct 30, 2006 1:34:54 PM (17 years ago)
Author:
kmccullo
Message:

Reviewed by Adam.

  • Fix some timezone issues and JavaScriptCore date tests. Addresses bugzilla 4930.
  • kjs/DateMath.h: (KJS::GregorianDateTime::GregorianDateTime): Here's the fix, to add parenthesis for order of precedence.
  • kjs/date_object.cpp: (KJS::DateProtoFunc::callAsFunction): (KJS::DateObjectImp::construct): memset not needed as GregorianDateTime initializes itself.
Location:
trunk/JavaScriptCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/JavaScriptCore/ChangeLog

    r17437 r17444  
     12006-10-30  Kevin McCullough  <KMcCullough@apple.com>
     2
     3        Reviewed by Adam.
     4
     5        - Fix some timezone issues and JavaScriptCore date tests.  Addresses bugzilla 4930.
     6
     7        * kjs/DateMath.h:
     8        (KJS::GregorianDateTime::GregorianDateTime): Here's the fix, to add parenthesis for order of precedence.
     9        * kjs/date_object.cpp:
     10        (KJS::DateProtoFunc::callAsFunction):
     11        (KJS::DateObjectImp::construct): memset not needed as GregorianDateTime initializes itself.
     12
    1132006-10-30  Darin Adler  <darin@apple.com>
    214
  • trunk/JavaScriptCore/kjs/DateMath.h

    r17372 r17444  
    112112        strncpy(timeZone, inTm.tm_zone, inZoneSize);
    113113#else
    114         utcOffset = static_cast<int>(getUTCOffset() / msPerSecond + isDST ? secondsPerHour : 0);
     114        utcOffset = static_cast<int>(getUTCOffset() / msPerSecond + (isDST ? secondsPerHour : 0));
    115115        timeZone = 0;
    116116#endif
  • trunk/JavaScriptCore/kjs/date_object.cpp

    r17372 r17444  
    552552    return jsNumber(ms);
    553553  case GetTimezoneOffset:
    554     return jsNumber(-gmtoffset(t) / 60);
     554    return jsNumber(-gmtoffset(t) / minutesPerHour);
    555555  case SetTime:
    556556    milli = roundValue(exec, args[0]);
     
    664664    } else {
    665665      GregorianDateTime t;
    666       memset(&t, 0, sizeof(t));
    667666      int year = args[0]->toInt32(exec);
    668667      t.year = (year >= 0 && year <= 99) ? year : year - 1900;
Note: See TracChangeset for help on using the changeset viewer.