Changeset 174697 in webkit


Ignore:
Timestamp:
Oct 14, 2014 12:30:08 PM (10 years ago)
Author:
jdiggs@igalia.com
Message:

REGRESSION(r174567): [GTK] Layout Tests platform/gtk/accessibility/aria-table-hierarchy.html and platform/gtk/accessibility/table-hierarchy.html fail
​https://bugs.webkit.org/show_bug.cgi?id=137697

These tests were overlooked when updating tests to reflect the correct
mapping for ColumnHeaderRole and RowHeaderRole in ATK.

Reviewed by Chris Fleizach.

  • platform/gtk/TestExpectations: Remove two failing tests.
  • platform/gtk/accessibility/aria-table-hierarchy-expected.txt: Updated expectations.
  • platform/gtk/accessibility/aria-table-hierarchy.html: Updated in-test shouldBe values for headers.
  • platform/gtk/accessibility/table-hierarchy-expected.txt: Updated expectations.
  • platform/gtk/accessibility/table-hierarchy.html: Updated in-test shouldBe values for headers.
Location:
trunk/LayoutTests
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r174685 r174697  
     12014-10-14  Joanmarie Diggs  <jdiggs@igalia.com>
     2
     3        REGRESSION(r174567): [GTK] Layout Tests platform/gtk/accessibility/aria-table-hierarchy.html and platform/gtk/accessibility/table-hierarchy.html fail
     4        https://bugs.webkit.org/show_bug.cgi?id=137697
     5
     6        These tests were overlooked when updating tests to reflect the correct
     7        mapping for ColumnHeaderRole and RowHeaderRole in ATK.
     8
     9        Reviewed by Chris Fleizach.
     10
     11        * platform/gtk/TestExpectations: Remove two failing tests.
     12        * platform/gtk/accessibility/aria-table-hierarchy-expected.txt: Updated expectations.
     13        * platform/gtk/accessibility/aria-table-hierarchy.html: Updated in-test shouldBe values for headers.
     14        * platform/gtk/accessibility/table-hierarchy-expected.txt: Updated expectations.
     15        * platform/gtk/accessibility/table-hierarchy.html: Updated in-test shouldBe values for headers.
     16
    1172014-10-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
    218

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r174685 r174697  
    21422142webkit.org/b/137695 media/video-controls-audiotracks-trackmenu.html [ Failure ]
    21432143
    2144 webkit.org/b/137697 platform/gtk/accessibility/aria-table-hierarchy.html [ Failure ]
    2145 webkit.org/b/137697 platform/gtk/accessibility/table-hierarchy.html [ Failure ]
    2146 
    21472144# Incomplete implementation of eventSender causes this test to fail
    21482145webkit.org/b/42194 fast/scrolling/scroll-select-list.html [ ImageOnlyFailure ]

  • trunk/LayoutTests/platform/gtk/accessibility/aria-table-hierarchy-expected.txt

    r131674 r174697  
    4040PASS table1.childAtIndex(i).role is 'AXRole: AXCell'
    4141PASS children is 6
    42 PASS table2.childAtIndex(i).role is 'AXRole: AXCell'
    43 PASS table2.childAtIndex(i).role is 'AXRole: AXCell'
     42PASS table2.childAtIndex(0).role is 'AXRole: AXColumnHeader'
     43PASS table2.childAtIndex(1).role is 'AXRole: AXColumnHeader'
    4444PASS table2.childAtIndex(i).role is 'AXRole: AXCell'
    4545PASS table2.childAtIndex(i).role is 'AXRole: AXCell'
    … …  
    5050PASS table3.childAtIndex(i).role is 'AXRole: AXCell'
    5151PASS children is 6
    52 PASS table4.childAtIndex(i).role is 'AXRole: AXCell'
    53 PASS table4.childAtIndex(i).role is 'AXRole: AXCell'
     52PASS table4.childAtIndex(0).role is 'AXRole: AXColumnHeader'
     53PASS table4.childAtIndex(1).role is 'AXRole: AXColumnHeader'
    5454PASS table4.childAtIndex(i).role is 'AXRole: AXCell'
    5555PASS table4.childAtIndex(i).role is 'AXRole: AXCell'

  • trunk/LayoutTests/platform/gtk/accessibility/aria-table-hierarchy.html

    r155282 r174697  
    5454        children = table2.childrenCount;
    5555        shouldBe("children", "6");
    56         for (i = 0; i < children; ++i) {
     56        shouldBe("table2.childAtIndex(0).role", "'AXRole: AXColumnHeader'");
     57        shouldBe("table2.childAtIndex(1).role", "'AXRole: AXColumnHeader'");
     58        for (i = 2; i < children; ++i) {
    5759            shouldBe("table2.childAtIndex(i).role", "'AXRole: AXCell'");
    5860        }
    … …  
    6466        children = table4.childrenCount;
    6567        shouldBe("children", "6");
    66         for (i = 0; i < children; ++i) {
     68        shouldBe("table4.childAtIndex(0).role", "'AXRole: AXColumnHeader'");
     69        shouldBe("table4.childAtIndex(1).role", "'AXRole: AXColumnHeader'");
     70        for (i = 2; i < children; ++i) {
    6771            shouldBe("table4.childAtIndex(i).role", "'AXRole: AXCell'");
    6872        }

  • trunk/LayoutTests/platform/gtk/accessibility/table-hierarchy-expected.txt

    r131674 r174697  
    3434PASS table1.childAtIndex(i).role is 'AXRole: AXCell'
    3535PASS children is 6
    36 PASS table2.childAtIndex(i).role is 'AXRole: AXCell'
    37 PASS table2.childAtIndex(i).role is 'AXRole: AXCell'
     36PASS table2.childAtIndex(0).role is 'AXRole: AXRowHeader'
     37PASS table2.childAtIndex(1).role is 'AXRole: AXRowHeader'
    3838PASS table2.childAtIndex(i).role is 'AXRole: AXCell'
    3939PASS table2.childAtIndex(i).role is 'AXRole: AXCell'
    … …  
    4444PASS table3.childAtIndex(i).role is 'AXRole: AXCell'
    4545PASS children is 6
    46 PASS table4.childAtIndex(i).role is 'AXRole: AXCell'
    47 PASS table4.childAtIndex(i).role is 'AXRole: AXCell'
     46PASS table4.childAtIndex(0).role is 'AXRole: AXRowHeader'
     47PASS table4.childAtIndex(1).role is 'AXRole: AXRowHeader'
    4848PASS table4.childAtIndex(i).role is 'AXRole: AXCell'
    4949PASS table4.childAtIndex(i).role is 'AXRole: AXCell'

  • trunk/LayoutTests/platform/gtk/accessibility/table-hierarchy.html

    r155282 r174697  
    5656        children = table2.childrenCount;
    5757        shouldBe("children", "6");
    58         for (i = 0; i < children; ++i) {
     58        shouldBe("table2.childAtIndex(0).role", "'AXRole: AXRowHeader'");
     59        shouldBe("table2.childAtIndex(1).role", "'AXRole: AXRowHeader'");
     60        for (i = 2; i < children; ++i) {
    5961            shouldBe("table2.childAtIndex(i).role", "'AXRole: AXCell'");
    6062        }
    … …  
    6668        children = table4.childrenCount;
    6769        shouldBe("children", "6");
    68         for (i = 0; i < children; ++i) {
     70        shouldBe("table4.childAtIndex(0).role", "'AXRole: AXRowHeader'");
     71        shouldBe("table4.childAtIndex(1).role", "'AXRole: AXRowHeader'");
     72        for (i = 2; i < children; ++i) {
    6973            shouldBe("table4.childAtIndex(i).role", "'AXRole: AXCell'");
    7074        }
Note: See TracChangeset for help on using the changeset viewer.