Changeset 174797 in webkit

Timestamp:

Oct 16, 2014 3:43:02 PM (10 years ago)

Author:

ddkilzer@apple.com

Message:

commit-queue: fails to close bugs after successfully landing patches
<​http://webkit.org/b/137794>

Reviewed by Alexey Proskuryakov.

• Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(Bugzilla.clear_attachment_flags): Change 'nr=0' to 'nr=1' to
tell Mechanize to use the second <textarea> on the page with
name="comment".

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/common/net/bugzilla/bugzilla.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2014-10-16  David Kilzer  <ddkilzer@apple.com>
+
+        commit-queue: fails to close bugs after successfully landing patches
+        <http://webkit.org/b/137794>
+
+        Reviewed by Alexey Proskuryakov.
+
+        * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
+        (Bugzilla.clear_attachment_flags): Change 'nr=0' to 'nr=1' to
+        tell Mechanize to use the second <textarea> on the page with
+        name="comment".
+
 2014-10-16  Brent Fulgham  <bfulgham@apple.com>
 

trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py

@@ -755 +755 @@
         self.browser.open(self.attachment_url_for_id(attachment_id, 'edit'))
         self.browser.select_form(nr=1)
-        self.browser.set_value(comment_text, name='comment', nr=0)
+        self.browser.set_value(comment_text, name='comment', nr=1)
         self._find_select_element_for_flag('review').value = ("X",)
         self._find_select_element_for_flag('commit-queue').value = ("X",)