Changeset 174924 in webkit

Timestamp:

Oct 20, 2014 11:12:54 PM (10 years ago)

Author:

commit-queue@webkit.org

Message:

[Coordinated Graphics] '-webkit-mask-image: -webkit-gradient' doesn't work for AC layer.
​https://bugs.webkit.org/show_bug.cgi?id=125326

Patch by YongGeol Jung <​yg48.jung@samsung.com> on 2014-10-20
Reviewed by Gyuyoung Kim.

Mask layer hasn't requested to synchronize with AC layer in CoordinatedGraphics so far.
That's why the mask layer isn't shown under CoordinatedGraphics.
Thus this patch lets the mask layer synchronize with the AC layer whenever AC layer is updated.

Below layout test case is related to this issue when --pixel test is enabled.
Unfortunately EFL WebKitTestRunner doesn't support AC mode yet.
When EFL test framework supports AC mode, the test will be passed.

Test: compositing/masks/mask-of-clipped-layer.html

• platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::syncPendingStateChangesIncludingSubLayers):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-10-20  YongGeol Jung  <yg48.jung@samsung.com>
+
+        [Coordinated Graphics] '-webkit-mask-image: -webkit-gradient' doesn't work for AC layer.
+        https://bugs.webkit.org/show_bug.cgi?id=125326
+
+        Reviewed by Gyuyoung Kim.
+
+        Mask layer hasn't requested to synchronize with AC layer in CoordinatedGraphics so far.
+        That's why the mask layer isn't shown under CoordinatedGraphics.
+        Thus this patch lets the mask layer synchronize with the AC layer whenever AC layer is updated.
+
+        Below layout test case is related to this issue when --pixel test is enabled.
+        Unfortunately EFL WebKitTestRunner doesn't support AC mode yet.
+        When EFL test framework supports AC mode, the test will be passed.
+
+        Test: compositing/masks/mask-of-clipped-layer.html
+
+        * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
+        (WebCore::CoordinatedGraphicsLayer::syncPendingStateChangesIncludingSubLayers):
+
 2014-10-17  Jeffrey Pfau  <jpfau@apple.com>
 

trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp

@@ -800 +800 @@
     }
 
+    if (maskLayer())
+        toCoordinatedGraphicsLayer(maskLayer())->syncPendingStateChangesIncludingSubLayers();
+
     for (size_t i = 0; i < children().size(); ++i)
         toCoordinatedGraphicsLayer(children()[i])->syncPendingStateChangesIncludingSubLayers();