Changeset 175053 in webkit


Ignore:
Timestamp:
Oct 22, 2014 10:16:44 AM (9 years ago)
Author:
commit-queue@webkit.org
Message:

XMLHttpRequest should support attribute responseURL as per latest XHR spec.
https://bugs.webkit.org/show_bug.cgi?id=136938

Patch by Shivakumar JM <shiva.jm@samsung.com> on 2014-10-22
Reviewed by Alexey Proskuryakov.

Source/WebCore:

Tests: http/tests/xmlhttprequest/basic-auth-responseURL.html

http/tests/xmlhttprequest/cross-origin-redirect-responseURL.html
http/tests/xmlhttprequest/redirect-credentials-responseURL.html
http/tests/xmlhttprequest/xmlhttprequest-responseURL.html

XMLHttpRequest should support attribute responseURL

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::responseURL):

  • xml/XMLHttpRequest.h:
  • xml/XMLHttpRequest.idl:

LayoutTests:

Added test to check responseURL attribute in XMLHttpRequest.

  • http/tests/xmlhttprequest/basic-auth-responseURL-expected.txt: Added.
  • http/tests/xmlhttprequest/basic-auth-responseURL.html: Added.
  • http/tests/xmlhttprequest/cross-origin-redirect-responseURL-expected.txt: Added.
  • http/tests/xmlhttprequest/cross-origin-redirect-responseURL.html: Added.
  • http/tests/xmlhttprequest/redirect-credentials-responseURL-expected.txt: Added.
  • http/tests/xmlhttprequest/redirect-credentials-responseURL.html: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-responseURL-expected.txt: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-responseURL.html: Added.
Location:
trunk
Files:
8 added
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r175050 r175053  
     12014-10-22  Shivakumar JM  <shiva.jm@samsung.com>
     2
     3        XMLHttpRequest should support attribute responseURL as per latest XHR spec.
     4        https://bugs.webkit.org/show_bug.cgi?id=136938
     5
     6        Reviewed by Alexey Proskuryakov.
     7
     8        Added test to check responseURL attribute in XMLHttpRequest.
     9
     10        * http/tests/xmlhttprequest/basic-auth-responseURL-expected.txt: Added.
     11        * http/tests/xmlhttprequest/basic-auth-responseURL.html: Added.
     12        * http/tests/xmlhttprequest/cross-origin-redirect-responseURL-expected.txt: Added.
     13        * http/tests/xmlhttprequest/cross-origin-redirect-responseURL.html: Added.
     14        * http/tests/xmlhttprequest/redirect-credentials-responseURL-expected.txt: Added.
     15        * http/tests/xmlhttprequest/redirect-credentials-responseURL.html: Added.
     16        * http/tests/xmlhttprequest/xmlhttprequest-responseURL-expected.txt: Added.
     17        * http/tests/xmlhttprequest/xmlhttprequest-responseURL.html: Added.
     18
    1192014-10-22  Carlos Garcia Campos  <cgarcia@igalia.com>
    220
  • trunk/Source/WebCore/ChangeLog

    r175052 r175053  
     12014-10-22  Shivakumar JM  <shiva.jm@samsung.com>
     2
     3        XMLHttpRequest should support attribute responseURL as per latest XHR spec.
     4        https://bugs.webkit.org/show_bug.cgi?id=136938
     5
     6        Reviewed by Alexey Proskuryakov.
     7
     8        Tests: http/tests/xmlhttprequest/basic-auth-responseURL.html
     9               http/tests/xmlhttprequest/cross-origin-redirect-responseURL.html
     10               http/tests/xmlhttprequest/redirect-credentials-responseURL.html
     11               http/tests/xmlhttprequest/xmlhttprequest-responseURL.html
     12
     13        XMLHttpRequest should support attribute responseURL
     14
     15        * xml/XMLHttpRequest.cpp:
     16        (WebCore::XMLHttpRequest::responseURL):
     17        * xml/XMLHttpRequest.h:
     18        * xml/XMLHttpRequest.idl:
     19
    1202014-10-22  Chris Dumez  <cdumez@apple.com>
    221
  • trunk/Source/WebCore/xml/XMLHttpRequest.cpp

    r174684 r175053  
    336336}
    337337
     338String XMLHttpRequest::responseURL() const
     339{
     340    URL responseURL(m_response.url());
     341    responseURL.removeFragmentIdentifier();
     342
     343    return responseURL.string();
     344}
     345
    338346void XMLHttpRequest::setLastSendLineAndColumnNumber(unsigned lineNumber, unsigned columnNumber)
    339347{
  • trunk/Source/WebCore/xml/XMLHttpRequest.h

    r174684 r175053  
    133133    ResponseTypeCode responseTypeCode() const { return m_responseTypeCode; }
    134134
     135    String responseURL() const;
     136
    135137    // response attribute has custom getter.
    136138    JSC::ArrayBuffer* responseArrayBuffer();
  • trunk/Source/WebCore/xml/XMLHttpRequest.idl

    r173552 r175053  
    9090    readonly attribute unsigned short status;
    9191    readonly attribute DOMString statusText;
     92    readonly attribute DOMString responseURL;
    9293
    9394    // Extension
Note: See TracChangeset for help on using the changeset viewer.