Changeset 175598 in webkit


Ignore:
Timestamp:
Nov 4, 2014 6:31:57 PM (9 years ago)
Author:
commit-queue@webkit.org
Message:

Web Inspector: Lots of TimelineDataGridNode asserts on reloads
https://bugs.webkit.org/show_bug.cgi?id=138387

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-11-04
Reviewed by Brian Burg.

The TimelineRuler.secondsPerPixel in the TimelineOverview is initialized
with a non-0 value and saved in a setting. However the TimelineRuler in
the OverviewTimelineView is not initialized with this value, and instead
initialized to 0. This patch initializes them to the same non-0 value.

  • UserInterface/Views/OverviewTimelineView.js:

(WebInspector.OverviewTimelineView.prototype.set secondsPerPixel):

  • UserInterface/Views/TimelineContentView.js:
Location:
trunk/Source/WebInspectorUI
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebInspectorUI/ChangeLog

    r175588 r175598  
     12014-11-04  Joseph Pecoraro  <pecoraro@apple.com>
     2
     3        Web Inspector: Lots of TimelineDataGridNode asserts on reloads
     4        https://bugs.webkit.org/show_bug.cgi?id=138387
     5
     6        Reviewed by Brian Burg.
     7
     8        The TimelineRuler.secondsPerPixel in the TimelineOverview is initialized
     9        with a non-0 value and saved in a setting. However the TimelineRuler in
     10        the OverviewTimelineView is not initialized with this value, and instead
     11        initialized to 0. This patch initializes them to the same non-0 value.
     12
     13        * UserInterface/Views/OverviewTimelineView.js:
     14        (WebInspector.OverviewTimelineView.prototype.set secondsPerPixel):
     15        * UserInterface/Views/TimelineContentView.js:
     16
    1172014-11-04  Joseph Pecoraro  <pecoraro@apple.com>
    218
  • trunk/Source/WebInspectorUI/UserInterface/Views/OverviewTimelineView.js

    r172435 r175598  
    7777    },
    7878
     79    set secondsPerPixel(x)
     80    {
     81        this._timelineRuler.secondsPerPixel = x;
     82    },
     83
    7984    shown: function()
    8085    {
  • trunk/Source/WebInspectorUI/UserInterface/Views/TimelineContentView.js

    r175203 r175598  
    5454
    5555    this._overviewTimelineView = new WebInspector.OverviewTimelineView(recording);
     56    this._overviewTimelineView.secondsPerPixel = this._timelineOverview.secondsPerPixel;
    5657
    5758    this._discreteTimelineViewMap = new Map;
Note: See TracChangeset for help on using the changeset viewer.