Changeset 175617 in webkit

Timestamp:

Nov 5, 2014 2:12:42 AM (9 years ago)

Author:

akling@apple.com

Message:

Simple line layout: support text-transform: lowercase|uppercase|capitalize
<​https://webkit.org/b/138406>

Reviewed by Antti Koivisto.

Source/WebCore:

Expand the simple line layout coverage to include all text-transform values.
Since the property works on the text string level, it's really only a matter
of removing the short-circuit.

Test: fast/text/simple-lines-text-transform.html

• rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor):

LayoutTests:

Add ref test for simple line layout with all text-transform values.

• fast/text/simple-lines-text-transform-expected.html: Added.
• fast/text/simple-lines-text-transform.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/text/simple-lines-text-transform-expected.html (added)
• LayoutTests/fast/text/simple-lines-text-transform.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/SimpleLineLayout.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2014-11-05  Andreas Kling  <akling@apple.com>
+
+        Simple line layout: support text-transform: lowercase|uppercase|capitalize
+        <https://webkit.org/b/138406>
+
+        Reviewed by Antti Koivisto.
+
+        Add ref test for simple line layout with all text-transform values.
+
+        * fast/text/simple-lines-text-transform-expected.html: Added.
+        * fast/text/simple-lines-text-transform.html: Added.
+
 2014-11-04  Michael Saboff  <msaboff@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-11-05  Andreas Kling  <akling@apple.com>
+
+        Simple line layout: support text-transform: lowercase|uppercase|capitalize
+        <https://webkit.org/b/138406>
+
+        Reviewed by Antti Koivisto.
+
+        Expand the simple line layout coverage to include all text-transform values.
+        Since the property works on the text string level, it's really only a matter
+        of removing the short-circuit.
+
+        Test: fast/text/simple-lines-text-transform.html
+
+        * rendering/SimpleLineLayout.cpp:
+        (WebCore::SimpleLineLayout::canUseFor):
+
 2014-11-05  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebCore/rendering/SimpleLineLayout.cpp

@@ -130 +130 @@
         return false;
     if (!style.wordSpacing().isZero() || style.letterSpacing())
-        return false;
-    if (style.textTransform() != TTNONE)
         return false;
     if (!style.isLeftToRightDirection())