Changeset 175628 in webkit

Timestamp:

Nov 5, 2014 10:43:30 AM (9 years ago)

Author:

jonowells@apple.com

Message:

Web Inspector: Add infrastructure for eslint based static analyzer
​https://bugs.webkit.org/show_bug.cgi?id=137890

Reviewed by Timothy Hatcher.

Adding a manager to analyze source code, return warnings (AnalyzerMessages), and cache warnings.

• UserInterface/Base/Main.js: Create analyzerManager singleton.
• UserInterface/Controllers/AnalyzerManager.js: Added.

(WebInspector.AnalyzerManager):
(set WebInspector.AnalyzerManager.prototype.getAnalyzerMessagesForSourceCode.):
(set WebInspector.AnalyzerManager.prototype.getAnalyzerMessagesForSourceCode):
(set WebInspector.AnalyzerManager.prototype.set get sourceCodeCanBeAnalyzed):
(set WebInspector.AnalyzerManager.prototype._handleSourceCodeContentDidChange):

• UserInterface/Main.html: Add new files.
• UserInterface/Models/AnalyzerMessage.js: Added.

(WebInspector.AnalyzerMessage):
(WebInspector.AnalyzerMessage.prototype.get sourceCodeLocation):
(WebInspector.AnalyzerMessage.prototype.get sourceCode):
(WebInspector.AnalyzerMessage.prototype.get text):
(WebInspector.AnalyzerMessage.prototype.get ruleIdentifier):

• UserInterface/Models/SourceCode.js: Added call to WebInspector.Object.addConstructorFunctions().

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Base/Main.js (modified) (2 diffs)
• UserInterface/Controllers/AnalyzerManager.js (added)
• UserInterface/Main.html (modified) (3 diffs)
• UserInterface/Models/AnalyzerMessage.js (added)
• UserInterface/Models/SourceCode.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2014-11-05  Jonathan Wells  <jonowells@apple.com>
+
+        Web Inspector: Add infrastructure for eslint based static analyzer
+        https://bugs.webkit.org/show_bug.cgi?id=137890
+
+        Reviewed by Timothy Hatcher.
+
+        Adding a manager to analyze source code, return warnings (AnalyzerMessages), and cache warnings.
+
+        * UserInterface/Base/Main.js: Create analyzerManager singleton.
+        * UserInterface/Controllers/AnalyzerManager.js: Added.
+        (WebInspector.AnalyzerManager):
+        (set WebInspector.AnalyzerManager.prototype.getAnalyzerMessagesForSourceCode.):
+        (set WebInspector.AnalyzerManager.prototype.getAnalyzerMessagesForSourceCode):
+        (set WebInspector.AnalyzerManager.prototype.set get sourceCodeCanBeAnalyzed):
+        (set WebInspector.AnalyzerManager.prototype._handleSourceCodeContentDidChange):
+        * UserInterface/Main.html: Add new files.
+        * UserInterface/Models/AnalyzerMessage.js: Added.
+        (WebInspector.AnalyzerMessage):
+        (WebInspector.AnalyzerMessage.prototype.get sourceCodeLocation):
+        (WebInspector.AnalyzerMessage.prototype.get sourceCode):
+        (WebInspector.AnalyzerMessage.prototype.get text):
+        (WebInspector.AnalyzerMessage.prototype.get ruleIdentifier):
+        * UserInterface/Models/SourceCode.js: Added call to WebInspector.Object.addConstructorFunctions().
+
 2014-11-04  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Base/Main.js

@@ -1 +1 @@
 /*
- * Copyright (C) 2013 Apple Inc. All rights reserved.
+ * Copyright (C) 2013-2014 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -101 +101 @@
     this.logManager = new WebInspector.LogManager;
     this.issueManager = new WebInspector.IssueManager;
+    this.analyzerManager = new WebInspector.AnalyzerManager;
     this.runtimeManager = new WebInspector.RuntimeManager;
     this.applicationCacheManager = new WebInspector.ApplicationCacheManager;

trunk/Source/WebInspectorUI/UserInterface/Main.html

@@ -176 +176 @@
 
     <script src="External/Esprima/esprima.js"></script>
+    <script src="External/ESLint/eslint.js"></script>
 
     <script src="Protocol/ApplicationCacheObserver.js"></script>
@@ -203 +204 @@
     <script src="Models/TimelineRecord.js"></script>
 
+    <script src="Models/AnalyzerMessage.js"></script>
     <script src="Models/ApplicationCacheFrame.js"></script>
     <script src="Models/ApplicationCacheManifest.js"></script>
@@ -459 +461 @@
     <script src="Controllers/CodeMirrorEditingController.js"></script>
 
+    <script src="Controllers/AnalyzerManager.js"></script>
     <script src="Controllers/ApplicationCacheManager.js"></script>
     <script src="Controllers/BranchManager.js"></script>

trunk/Source/WebInspectorUI/UserInterface/Models/SourceCode.js

@@ -37 +37 @@
 };
 
+WebInspector.Object.addConstructorFunctions(WebInspector.SourceCode);
+
 WebInspector.SourceCode.Event = {
     ContentDidChange: "source-code-content-did-change",