Changeset 175629 in webkit

Timestamp:

Nov 5, 2014 11:57:27 AM (9 years ago)

Author:

ap@apple.com

Message:

Incorrect sandbox_check in RemoteInspector.mm
​https://bugs.webkit.org/show_bug.cgi?id=138408

Reviewed by Joseph Pecoraro.

• inspector/remote/RemoteInspector.mm:

(Inspector::canAccessWebInspectorMachPort):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/remote/RemoteInspector.mm (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2014-11-05  Alexey Proskuryakov  <ap@apple.com>
+
+        Incorrect sandbox_check in RemoteInspector.mm
+        https://bugs.webkit.org/show_bug.cgi?id=138408
+
+        Reviewed by Joseph Pecoraro.
+
+        * inspector/remote/RemoteInspector.mm:
+        (Inspector::canAccessWebInspectorMachPort):
+
 2014-11-03  Dean Jackson  <dino@apple.com>
 

trunk/Source/JavaScriptCore/inspector/remote/RemoteInspector.mm

@@ -44 +44 @@
 #else
 enum sandbox_filter_type {
-    SANDBOX_FILTER_GLOBAL_NAME,
+    SANDBOX_FILTER_GLOBAL_NAME = 2,
 };
 #endif
-extern "C" {
-    int sandbox_check(pid_t, const char *operation, enum sandbox_filter_type, ...);
-}
+
+extern "C" int sandbox_check(pid_t, const char *operation, enum sandbox_filter_type, ...);
+extern "C" const enum sandbox_filter_type SANDBOX_CHECK_NO_REPORT;
 
 #if PLATFORM(IOS)
@@ -59 +59 @@
 static bool canAccessWebInspectorMachPort()
 {
-    return sandbox_check(getpid(), "mach-lookup", SANDBOX_FILTER_GLOBAL_NAME, WIRXPCMachPortName) == 0;
+    return sandbox_check(getpid(), "mach-lookup", static_cast<enum sandbox_filter_type>(SANDBOX_FILTER_GLOBAL_NAME | SANDBOX_CHECK_NO_REPORT), WIRXPCMachPortName) == 0;
 }